From: "Daniel P. Berrange" <berrange@redhat.com>
To: Josh Durgin <joshd@hq.newdream.net>
Cc: libvir-list@redhat.com, ceph-devel@vger.kernel.org,
sheepdog@lists.wpkg.org
Subject: Re: [libvirt] [PATCH 1/2] qemu: Add RBD support and some network disk fixes
Date: Thu, 9 Dec 2010 11:10:07 +0000 [thread overview]
Message-ID: <20101209111007.GF5142@redhat.com> (raw)
In-Reply-To: <4CFE9172.6030302@hq.newdream.net>
On Tue, Dec 07, 2010 at 11:56:34AM -0800, Josh Durgin wrote:
>
> Changes common to all network disks:
> -Make source name optional in the domain schema, since NBD doesn't use it
> -Add a hostName type to the domain schema, and use it instead of genericName, which doesn't include .
> -Don't leak host names or ports
> -Set the source protocol in qemuParseCommandline
>
> Signed-off-by: Josh Durgin <joshd@hq.newdream.net>
> ---
> docs/schemas/domain.rng | 11 +++-
> src/conf/domain_conf.c | 25 +++++++-
> src/conf/domain_conf.h | 1 +
> src/qemu/qemu_conf.c | 143 ++++++++++++++++++++++++++++++++++++++++++++---
> 4 files changed, 165 insertions(+), 15 deletions(-)
ACK
Daniel
next prev parent reply other threads:[~2010-12-09 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 20:49 [PATCH] add network disk support MORITA Kazutaka
2010-12-02 13:19 ` Daniel P. Berrange
[not found] ` <20101202131928.GV2502-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-12-06 7:24 ` [PATCH v2] " MORITA Kazutaka
2010-12-07 19:54 ` [PATCH 0/2] rbd " Josh Durgin
[not found] ` <1291620249-19645-1-git-send-email-morita.kazutaka-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2010-12-07 19:56 ` [PATCH 1/2] qemu: Add RBD support and some network disk fixes Josh Durgin
2010-12-09 11:10 ` Daniel P. Berrange [this message]
2010-12-07 19:57 ` [PATCH 2/2] tests: Add tests for network disks Josh Durgin
2010-12-09 11:10 ` [libvirt] " Daniel P. Berrange
2010-12-09 11:09 ` [PATCH v2] add network disk support Daniel P. Berrange
2010-12-09 19:13 ` [libvirt] " Eric Blake
2010-12-09 21:31 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209111007.GF5142@redhat.com \
--to=berrange@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=joshd@hq.newdream.net \
--cc=libvir-list@redhat.com \
--cc=sheepdog@lists.wpkg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox