From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sage Weil <sage@newdream.net>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, ceph-devel@vger.kernel.org
Subject: Re: ceph: move encode_fh to new API
Date: Thu, 19 Apr 2012 00:02:44 +0100 [thread overview]
Message-ID: <20120418230244.GI6589@ZenIV.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1204181035450.15730@cobra.newdream.net>
On Wed, Apr 18, 2012 at 10:39:08AM -0700, Sage Weil wrote:
> On Wed, 18 Apr 2012, Dan Carpenter wrote:
> > Hello Sage Weil,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch f59919a07e03: "ceph: move encode_fh to new API" from Apr 5,
> > 2012, leads to the following Smatch complaint:
> >
> > fs/ceph/export.c:85 ceph_encode_fh()
> > error: we previously assumed 'dentry' could be null (see line 67)
>
> Thanks, Dan! This caught a minor bug.
>
> Al, can you update f59919a07e0335358d9470289cf46ffb83b7d2f9 in your
> for-next with the following?
Folded and pushed...
prev parent reply other threads:[~2012-04-18 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 9:40 ceph: move encode_fh to new API Dan Carpenter
2012-04-18 17:39 ` Sage Weil
2012-04-18 23:02 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418230244.GI6589@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox