From: David Disseldorp <ddiss@suse.de>
To: Gregory Farnum <greg@inktank.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] mds: remove waiting lock before merging with neighbours
Date: Sat, 24 Aug 2013 14:02:49 +0200 [thread overview]
Message-ID: <20130824140249.7a6493c1@plati.site> (raw)
In-Reply-To: <CAPYLRzgeWsdxyqWNRykH1Ac+TChQwFh4PKmP7D81jc89YOZJ9w@mail.gmail.com>
On Fri, 23 Aug 2013 13:58:56 -0700
Gregory Farnum <greg@inktank.com> wrote:
> When handling a lock request, the MDS calls adjust_locks() to merge
> the new lock with available neighbours. If the new lock is merged,
> then the waiting_locks entry is not located in the subsequent
> remove_waiting() call because adjust_locks changed the new lock to
> include the old locks.
> This fix ensures that the waiting_locks entry is removed prior to
> modification during merge.
Looks good.
> And it's now merged into master and backported to dumpling. Thank you very much!
Great, thanks Gregory.
Cheers, David
prev parent reply other threads:[~2013-08-24 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 15:05 [PATCH] mds: remove waiting lock before merging with neighbours David Disseldorp
2013-08-01 12:11 ` David Disseldorp
2013-08-01 18:07 ` Sage Weil
2013-08-23 20:58 ` Gregory Farnum
2013-08-24 12:02 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130824140249.7a6493c1@plati.site \
--to=ddiss@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=greg@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox