CEPH filesystem development
 help / color / mirror / Atom feed
From: Guangliang Zhao <lucienchao@gmail.com>
To: Alex Elder <elder@ieee.org>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 2/3 v2] rbd: extend the operation type
Date: Thu, 13 Mar 2014 13:32:19 +0800	[thread overview]
Message-ID: <20140313053219.GA8759@x230> (raw)
In-Reply-To: <53213868.1010808@ieee.org>

On Wed, Mar 12, 2014 at 11:47:36PM -0500, Alex Elder wrote:
> On 03/12/2014 10:21 PM, Guangliang Zhao wrote:
> > It could only handle the read and write operations now,
> > extend it for the coming discard support.
> 
> Wow, it looks like you took all of my suggestions.
> 
> This looks good.

Good comment again :-)

Thanks.

> 
> Reviewed-by: Alex Elder <elder@linaro.org>
> 
> > Signed-off-by: Guangliang Zhao <lucienchao@gmail.com>
> > ---
> >  drivers/block/rbd.c |   96 +++++++++++++++++++++++++++++++++------------------
> >  1 file changed, 63 insertions(+), 33 deletions(-)
> > 
> > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> > index 2d48858..fc5bf37 100644
> > --- a/drivers/block/rbd.c
> > +++ b/drivers/block/rbd.c
> > @@ -209,6 +209,11 @@ enum obj_request_type {
> >  	OBJ_REQUEST_NODATA, OBJ_REQUEST_BIO, OBJ_REQUEST_PAGES
> >  };
> >  
> 
> . . .
> 

-- 
Best regards,
Guangliang

  reply	other threads:[~2014-03-13  5:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13  3:21 [PATCH 1/3 v2] rbd: skip the copyup when an entire object writing Guangliang Zhao
2014-03-13  3:21 ` [PATCH 2/3 v2] rbd: extend the operation type Guangliang Zhao
2014-03-13  4:47   ` Alex Elder
2014-03-13  5:32     ` Guangliang Zhao [this message]
2014-03-27 22:05   ` Josh Durgin
2014-03-13  3:21 ` [PATCH 3/3 v2] rbd: add discard support for rbd Guangliang Zhao
2014-03-13  4:49   ` Alex Elder
2014-03-27 23:26   ` Josh Durgin
2014-03-13  4:45 ` [PATCH 1/3 v2] rbd: skip the copyup when an entire object writing Alex Elder
2014-03-27 21:48 ` Josh Durgin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140313053219.GA8759@x230 \
    --to=lucienchao@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=elder@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox