From: Christoph Hellwig <hch@lst.de>
To: Ilya Dryomov <ilya.dryomov@inktank.com>
Cc: Alex Elder <elder@ieee.org>, Yehuda Sadeh <yehuda@inktank.com>,
Sage Weil <sage@inktank.com>, Alex Elder <elder@kernel.org>,
Alexandre DERUMIER <aderumier@odiso.com>,
Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH v2] rbd: convert to blk-mq
Date: Tue, 13 Jan 2015 17:19:02 +0100 [thread overview]
Message-ID: <20150113161901.GA23547@lst.de> (raw)
In-Reply-To: <CALFYKtBUONtvGDJtM92bna9utkvnpTHxbL--5P+N3oirgqU7Bg@mail.gmail.com>
On Mon, Jan 12, 2015 at 08:10:48PM +0300, Ilya Dryomov wrote:
> Why is this call here? Why not above or below? I doubt it makes much
> difference, but from a clarity standpoint at least, shouldn't it be
> placed after all the checks and allocations, say before the call to
> rbd_img_request_submit()?
The idea is to do it before doing real work, but after the request
is set up far enough that a cancallation works. For rbd that doesn't do
timeouts or cancellations it really doesn't matter too much. I've
moved it a little further down after the next trivial check now.
> Expanding on REQ_TYPE_FS comment, isn't blk_mq_end_request() enough?
> Swap blk_end_request_all() for blk_mq_end_request() and get rid of err
> label?
The blk_end_request_all should be gone and sneaked back in due to a sloppy
rebase.
next prev parent reply other threads:[~2015-01-13 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 18:31 [PATCH] rbd: convert to blk-mq Christoph Hellwig
2015-01-10 23:40 ` Alex Elder
2015-01-12 12:40 ` [PATCH v2] " Christoph Hellwig
[not found] ` <1682521695.3794355.1421069570592.JavaMail.zimbra@oxygem.tv>
2015-01-12 13:32 ` Alexandre DERUMIER
2015-01-12 17:10 ` Ilya Dryomov
2015-01-13 16:19 ` Christoph Hellwig [this message]
2015-01-13 16:20 ` [PATCH v3] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113161901.GA23547@lst.de \
--to=hch@lst.de \
--cc=aderumier@odiso.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=ilya.dryomov@inktank.com \
--cc=sage@inktank.com \
--cc=yehuda@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox