From: Mykola Golub <mgolub@mirantis.com>
To: Sage Weil <sweil@redhat.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: ceph osd df
Date: Fri, 16 Jan 2015 17:51:24 +0200 [thread overview]
Message-ID: <20150116155123.GA11113@gmail.com> (raw)
In-Reply-To: <20150112082250.GA31325@gmail.com>
On Mon, Jan 12, 2015 at 10:22:51AM +0200, Mykola Golub wrote:
> On Sun, Jan 11, 2015 at 09:33:57AM -0800, Sage Weil wrote:
>
> > By the way I took another look and I'm not sure that it is worth
> > duplicating all of the tree logic for a tree view. It seems easier to
> > either include this optionally in the tree output (the utilzation calc is
> > simpler than the tree traversal stack)... or generalize it somehow?
>
> Note, we already have duplication, at least CrushWrapper::dump_tree()
> and OSDMap::print_tree(). I will work on generalization, I think some
> tree dumper in CrushWrapper.
I have updated the code. https://github.com/ceph/ceph/pull/3347
--
Mykola Golub
prev parent reply other threads:[~2015-01-16 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 19:03 ceph osd df Sage Weil
2015-01-10 9:31 ` Mykola Golub
2015-01-10 18:39 ` Sage Weil
2015-01-11 16:31 ` Mykola Golub
2015-01-11 17:33 ` Sage Weil
2015-01-12 8:22 ` Mykola Golub
2015-01-16 15:51 ` Mykola Golub [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116155123.GA11113@gmail.com \
--to=mgolub@mirantis.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sweil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox