From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool Date: Mon, 29 Jul 2019 16:57:21 -0400 Message-ID: <20190729205721.GB3760@redhat.com> References: <20190724042518.14363-1-jhubbard@nvidia.com> <20190724042518.14363-4-jhubbard@nvidia.com> <20190724053053.GA18330@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190724053053.GA18330@infradead.org> Sender: netdev-owner@vger.kernel.org To: Christoph Hellwig Cc: john.hubbard@gmail.com, Andrew Morton , Alexander Viro , Anna Schumaker , "David S . Miller" , Dominique Martinet , Eric Van Hensbergen , Jason Gunthorpe , Jason Wang , Jens Axboe , Latchesar Ionkov , "Michael S . Tsirkin" , Miklos Szeredi , Trond Myklebust , Christoph Hellwig , Matthew Wilcox , linux-mm@kvack.org, LKML , ceph-devel@vger.kernel.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-cifs@vger.kernel. List-Id: ceph-devel.vger.kernel.org On Tue, Jul 23, 2019 at 10:30:53PM -0700, Christoph Hellwig wrote: > On Tue, Jul 23, 2019 at 09:25:09PM -0700, john.hubbard@gmail.com wrote: > > From: John Hubbard > > > > In commit d241a95f3514 ("block: optionally mark pages dirty in > > bio_release_pages"), new "bool mark_dirty" argument was added to > > bio_release_pages. > > > > In upcoming work, another bool argument (to indicate that the pages came > > from get_user_pages) is going to be added. That's one bool too many, > > because it's not desirable have calls of the form: > > All pages releases by bio_release_pages should come from > get_get_user_pages, so I don't really see the point here. No they do not all comes from GUP for see various callers of bio_check_pages_dirty() for instance iomap_dio_zero() I have carefully tracked down all this and i did not do anyconvertion just for the fun of it :) Cheers, Jérôme