From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr Date: Tue, 5 Nov 2019 10:48:30 +0100 Message-ID: <20191105094830.GL22379@quack2.suse.cz> References: <20191104215253.141818-1-salyzyn@android.com> <20191104215253.141818-2-salyzyn@android.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20191104215253.141818-2-salyzyn@android.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Mark Salyzyn Cc: Latchesar Ionkov , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Jan Kara , linux-doc@vger.kernel.org, linux-integrity@vger.kernel.org, Greg Kroah-Hartman , Martin Brandenburg , samba-technical@lists.samba.org, Dominique Martinet , Artem Bityutskiy , Adrian Hunter , David Howells , Chris Mason , "David S. Miller" , Andreas Dilger , Eric Paris , Mauro Carvalho Chehab , netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, Mike Marshall , linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.orgAndreas List-Id: ceph-devel.vger.kernel.org > @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler, > break; > case 1: > data = buf; > - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); > + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); > break; > case 2: > data = buf; > - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned); > + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned); > break; > case 3: These scnprintf() changes (and there are more in the patch) probably shouldn't be here... Otherwise the patch still looks good to me :). Honza -- Jan Kara SUSE Labs, CR