CEPH filesystem development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org
Cc: idryomov@gmail.com, dhowells@redhat.com, linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 0/3] ceph: uninline data on open instead of write
Date: Fri, 21 Jan 2022 09:18:35 -0500	[thread overview]
Message-ID: <20220121141838.110954-1-jlayton@kernel.org> (raw)

The inline_data feature for ceph allowed you to store the first chunk of
file data in the MDS instead of the OSD, using the cap system to keep
things in sync. The kernel client implementation has always been a bit
buggy and racy, and user uptake of this feature was pretty low.

A couple of years ago, we decided to formally deprecate the inline_data
feature entirely, and marked it as such in the Octopus release. We're
still waiting on a few pieces in userland [1] before we can rip out
support there so we need to keep support for inline_data in the client
for now.

This patch series changes the client from uninlining the data on the
first write, to doing so at open time. This gets the uninlining out of
the more fiddly write codepaths, and fits with the larger goal of
aggressively deprecating inline_data.

The original series was proposed by David. I added fixes for a few bugs
found during testing and rolled in a related fix to change how we acquire
the inode pointer.

[1]: https://tracker.ceph.com/issues/52916

David Howells (2):
  ceph: Make ceph_netfs_issue_op() handle inlined data
  ceph: Uninline the data on a file opened for writing

Jeff Layton (1):
  ceph: switch netfs read ops to use rreq->inode instead of
    rreq->mapping->host

 fs/ceph/addr.c  | 239 +++++++++++++++++++++++-------------------------
 fs/ceph/file.c  |  32 +++----
 fs/ceph/super.h |   2 +-
 3 files changed, 129 insertions(+), 144 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-01-21 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21 14:18 Jeff Layton [this message]
2022-01-21 14:18 ` [PATCH v3 1/3] ceph: switch netfs read ops to use rreq->inode instead of rreq->mapping->host Jeff Layton
2022-01-21 14:18 ` [PATCH v3 2/3] ceph: Make ceph_netfs_issue_op() handle inlined data Jeff Layton
2022-01-21 14:57   ` David Howells
2022-01-21 15:18     ` Jeff Layton
2022-01-21 14:18 ` [PATCH v3 3/3] ceph: Uninline the data on a file opened for writing Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220121141838.110954-1-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dhowells@redhat.com \
    --cc=idryomov@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox