CEPH filesystem development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org
Cc: idryomov@gmail.com
Subject: [RFC PATCH 0/5] libceph: add support for sparse reads to msgr2/crc
Date: Tue, 15 Feb 2022 09:50:36 -0500	[thread overview]
Message-ID: <20220215145041.26065-1-jlayton@kernel.org> (raw)

This is a first stab at a patchset to add support for sparse reads to
libceph. This is a prerequisite for fscrypt support, since we need to be
able to know whether a region is sparse in order to know whether we need
to decrypt it.

The patches basically work at this point, but it's still a RFC
for a few reasons:

1) the ms_mode=secure and ms_mode=legacy codepaths are not yet
supported. "legacy" doesn't look too bad, but "secure" is a bit
tougher, as I'd like to avoid extra buffering.

2) the OSD currently throws back -EINVAL on a sparse read if an extent
has a non-zero truncate_seq. I've opened this bug to request that this
be remedied: https://tracker.ceph.com/issues/54280

3) I'm not sure I got the revoke_at_* patch correct. I added a new field
to the v2_info structure. Maybe there is some better way to handle that?
What's the best way to test the revocation codepaths?

I ran this through xfstests yesterday, and several of them failed
because of #2 above, but it didn't oops!

Jeff Layton (5):
  libceph: allow ceph_msg_data_advance to advance more than a page
  libceph: add sparse read support to msgr2 crc state machine
  libceph: add sparse read support to OSD client
  libceph: add revoke support for sparse data
  ceph: switch to sparse reads

 fs/ceph/addr.c                  |   2 +-
 fs/ceph/file.c                  |   4 +-
 include/linux/ceph/messenger.h  |  20 ++++
 include/linux/ceph/osd_client.h |  37 ++++++
 net/ceph/messenger.c            |  12 +-
 net/ceph/messenger_v2.c         | 195 +++++++++++++++++++++++++++++---
 net/ceph/osd_client.c           | 161 +++++++++++++++++++++++++-
 7 files changed, 408 insertions(+), 23 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-02-15 14:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 14:50 Jeff Layton [this message]
2022-02-15 14:50 ` [RFC PATCH 1/5] libceph: allow ceph_msg_data_advance to advance more than a page Jeff Layton
2022-02-15 14:50 ` [RFC PATCH 2/5] libceph: add sparse read support to msgr2 crc state machine Jeff Layton
2022-02-15 14:50 ` [RFC PATCH 3/5] libceph: add sparse read support to OSD client Jeff Layton
2022-02-15 14:50 ` [RFC PATCH 4/5] libceph: add revoke support for sparse data Jeff Layton
2022-02-15 14:50 ` [RFC PATCH 5/5] ceph: switch to sparse reads Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220215145041.26065-1-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox