From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: David Howells <dhowells@redhat.com>, Xiubo Li <xiubli@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ceph: uninitialized variable in debug output
Date: Tue, 8 Mar 2022 16:30:51 +0300 [thread overview]
Message-ID: <20220308133051.GK3315@kadam> (raw)
In-Reply-To: <1b892ba94ba4fe23b80fdfe29c92fdcde35e0b5a.camel@kernel.org>
On Tue, Mar 08, 2022 at 08:28:21AM -0500, Jeff Layton wrote:
> On Tue, 2022-03-08 at 08:24 -0500, Jeff Layton wrote:
> > On Tue, 2022-03-08 at 09:36 +0000, David Howells wrote:
> > > Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > >
> > > > + u64 inline_version = -1;
> > >
> > > ULLONG_MAX?
> > >
> > > David
> > >
> >
> > ...or maybe CEPH_INLINE_NONE, which is:
> >
> > #define CEPH_INLINE_NONE ((__u64)-1)
> >
>
> I went ahead and merged the patch into our testing branch, with the
> change to use CEPH_INLINE_NONE instead.
I liked CEPH_INLINE_NONE so I was resending it right now... But thanks!
regards,
dan carpenter
prev parent reply other threads:[~2022-03-08 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 14:21 [PATCH] ceph: uninitialized variable in debug output Dan Carpenter
2022-03-08 0:11 ` Xiubo Li
2022-03-08 9:36 ` David Howells
2022-03-08 13:24 ` Jeff Layton
2022-03-08 13:28 ` Jeff Layton
2022-03-08 13:30 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308133051.GK3315@kadam \
--to=dan.carpenter@oracle.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox