From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org, dhowells@redhat.com
Cc: idryomov@gmail.com, xiubli@redhat.com, linux-cachefs@redhat.com
Subject: [RFC PATCH 1/5] netfs: don't error out on short DIO reads
Date: Thu, 7 Apr 2022 08:02:20 -0400 [thread overview]
Message-ID: <20220407120224.76156-2-jlayton@kernel.org> (raw)
In-Reply-To: <20220407120224.76156-1-jlayton@kernel.org>
There's no reason that userland can't request to read beyond the EOF. A
short read is expected in that situation.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/netfs/io.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/netfs/io.c b/fs/netfs/io.c
index aaaafc3e1601..b94f2d27127e 100644
--- a/fs/netfs/io.c
+++ b/fs/netfs/io.c
@@ -728,11 +728,6 @@ ssize_t netfs_begin_read(struct netfs_io_request *rreq, bool sync)
}
ret = rreq->error;
- if (ret == 0 && rreq->submitted < rreq->len &&
- rreq->origin == NETFS_DIO_READ) {
- trace_netfs_failure(rreq, NULL, ret, netfs_fail_short_read);
- ret = -EIO;
- }
if (ret == 0)
ret = netfs_dio_copy_to_dest(rreq);
if (ret == 0) {
--
2.35.1
next prev parent reply other threads:[~2022-04-07 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:02 [RFC PATCH 0/5] ceph: convert to netfs_direct_read_iter Jeff Layton
2022-04-07 12:02 ` Jeff Layton [this message]
2022-04-07 12:02 ` [RFC PATCH 2/5] ceph: set rsize in netfs_i_context from mount options Jeff Layton
2022-04-07 12:02 ` [RFC PATCH 3/5] ceph: Use the provided iterator in ceph_netfs_issue_op() Jeff Layton
2022-04-07 12:02 ` [RFC PATCH 4/5] ceph: enhance dout messages in issue_read codepaths Jeff Layton
2022-04-07 12:02 ` [RFC PATCH 5/5] ceph: switch to netfs_direct_read_iter Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407120224.76156-2-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=linux-cachefs@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox