From: xiubli@redhat.com
To: ceph-devel@vger.kernel.org
Cc: idryomov@gmail.com, jlayton@kernel.org, vshankar@redhat.com,
mchangir@redhat.com, Xiubo Li <xiubli@redhat.com>
Subject: [PATCH v4 1/3] libceph: fail the sparse-read if there still has data in socket
Date: Thu, 18 Jan 2024 18:50:45 +0800 [thread overview]
Message-ID: <20240118105047.792879-2-xiubli@redhat.com> (raw)
In-Reply-To: <20240118105047.792879-1-xiubli@redhat.com>
From: Xiubo Li <xiubli@redhat.com>
Once this happens that means there have bugs.
URL: https://tracker.ceph.com/issues/63586
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
net/ceph/osd_client.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 9be80d01c1dc..f8029b30a3fb 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -5912,6 +5912,13 @@ static int osd_sparse_read(struct ceph_connection *con,
fallthrough;
case CEPH_SPARSE_READ_DATA:
if (sr->sr_index >= count) {
+ if (sr->sr_datalen) {
+ pr_warn_ratelimited("sr_datalen %u sr_index %d count %u\n",
+ sr->sr_datalen, sr->sr_index,
+ count);
+ return -EREMOTEIO;
+ }
+
sr->sr_state = CEPH_SPARSE_READ_HDR;
goto next_op;
}
@@ -5919,6 +5926,8 @@ static int osd_sparse_read(struct ceph_connection *con,
eoff = sr->sr_extent[sr->sr_index].off;
elen = sr->sr_extent[sr->sr_index].len;
+ sr->sr_datalen -= elen;
+
dout("[%d] ext %d off 0x%llx len 0x%llx\n",
o->o_osd, sr->sr_index, eoff, elen);
--
2.43.0
next prev parent reply other threads:[~2024-01-18 10:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 10:50 [PATCH v4 0/3] libceph: fix sparse-read failure bug xiubli
2024-01-18 10:50 ` xiubli [this message]
2024-01-18 14:03 ` [PATCH v4 1/3] libceph: fail the sparse-read if there still has data in socket Jeff Layton
2024-01-19 4:07 ` Xiubo Li
2024-01-19 11:03 ` Jeff Layton
2024-01-22 3:17 ` Xiubo Li
2024-01-18 10:50 ` [PATCH v4 2/3] libceph: rename read_sparse_msg_XX to read_partial_sparse_msg_XX xiubli
2024-01-18 14:04 ` Jeff Layton
2024-01-18 10:50 ` [PATCH v4 3/3] libceph: just wait for more data to be available on the socket xiubli
2024-01-18 14:36 ` Jeff Layton
2024-01-18 18:24 ` Jeff Layton
2024-01-19 4:35 ` Xiubo Li
2024-01-19 11:09 ` Jeff Layton
2024-01-22 2:52 ` Xiubo Li
2024-01-22 11:44 ` Jeff Layton
2024-01-22 15:02 ` Jeff Layton
2024-01-22 16:55 ` Ilya Dryomov
2024-01-22 17:14 ` Jeff Layton
2024-01-22 19:41 ` Ilya Dryomov
2024-01-23 0:53 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118105047.792879-2-xiubli@redhat.com \
--to=xiubli@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=mchangir@redhat.com \
--cc=vshankar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox