From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Ofir Gal <ofir.gal@volumez.com>,
davem@davemloft.net, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
ceph-devel@vger.kernel.org, dhowells@redhat.com,
edumazet@google.com, pabeni@redhat.com, kbusch@kernel.org,
axboe@kernel.dk, hch@lst.de, philipp.reisner@linbit.com,
lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com,
idryomov@gmail.com, xiubli@redhat.com
Subject: Re: [PATCH v2 1/4] net: introduce helper sendpages_ok()
Date: Tue, 4 Jun 2024 06:27:38 +0200 [thread overview]
Message-ID: <20240604042738.GA28853@lst.de> (raw)
In-Reply-To: <86e60615-9286-4c9c-bffc-72304bd3cc1f@grimberg.me>
On Tue, Jun 04, 2024 at 12:27:06AM +0300, Sagi Grimberg wrote:
>>> I still don't understand how a page in the middle of a contiguous range ends
>>> up coming from the slab while others don't.
>> I haven't investigate the origin of the IO
>> yet. I suspect the first 2 pages are the superblocks of the raid
>> (mdp_superblock_1 and bitmap_super_s) and the rest of the IO is the bitmap.
>
> Well, if these indeed are different origins and just *happen* to be a
> mixture
> of slab originated pages and non-slab pages combined together in a single
> bio of a bvec entry,
> I'd suspect that it would be more beneficial to split the bvec (essentially
> not allow bio_add_page
> to append the page to tail bvec depending on a queue limit (similar to how
> we handle sg gaps).
So you want to add a PageSlab check to bvec_try_merge_page? That sounds
fairly expensive..
next prev parent reply other threads:[~2024-06-04 4:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 14:24 [PATCH v2 0/4] bugfix: Introduce sendpages_ok() to check sendpage_ok() on contiguous pages Ofir Gal
2024-05-30 14:24 ` [PATCH v2 1/4] net: introduce helper sendpages_ok() Ofir Gal
2024-05-31 7:32 ` Christoph Hellwig
2024-05-31 8:51 ` Sagi Grimberg
2024-06-03 12:35 ` Ofir Gal
2024-06-03 21:27 ` Sagi Grimberg
2024-06-04 4:27 ` Christoph Hellwig [this message]
2024-06-04 8:24 ` Sagi Grimberg
2024-06-04 13:01 ` Sagi Grimberg
2024-06-06 12:57 ` Ofir Gal
2024-06-06 13:08 ` Christoph Hellwig
2024-06-06 13:18 ` Ofir Gal
2024-06-06 13:52 ` Christoph Hellwig
2024-06-06 15:42 ` Ofir Gal
2024-05-30 14:24 ` [PATCH v2 2/4] nvme-tcp: use sendpages_ok() instead of sendpage_ok() Ofir Gal
2024-05-31 7:32 ` Christoph Hellwig
2024-05-30 14:24 ` [PATCH v2 3/4] drbd: " Ofir Gal
2024-06-04 14:43 ` Christoph Böhmwalder
2024-05-30 14:24 ` [PATCH v2 4/4] libceph: " Ofir Gal
2024-05-31 7:32 ` [PATCH v2 0/4] bugfix: Introduce sendpages_ok() to check sendpage_ok() on contiguous pages Christoph Hellwig
2024-06-01 22:36 ` Jakub Kicinski
2024-06-04 4:30 ` Christoph Hellwig
2024-06-04 14:42 ` Jakub Kicinski
2024-06-05 7:27 ` Christoph Hellwig
2024-06-01 22:34 ` Jakub Kicinski
2024-06-02 7:48 ` Sagi Grimberg
2024-06-03 9:07 ` Hannes Reinecke
2024-06-03 12:46 ` Ofir Gal
2024-06-03 7:24 ` Hannes Reinecke
2024-06-03 12:49 ` Ofir Gal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604042738.GA28853@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=christoph.boehmwalder@linbit.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=idryomov@gmail.com \
--cc=kbusch@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=ofir.gal@volumez.com \
--cc=pabeni@redhat.com \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).