* [PATCH] ceph: stop selecting CRYPTO and CRYPTO_AES
@ 2025-12-04 6:11 Eric Biggers
2025-12-04 16:10 ` Ilya Dryomov
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2025-12-04 6:11 UTC (permalink / raw)
To: Xiubo Li, Ilya Dryomov, ceph-devel; +Cc: Eric Biggers
None of the CEPH_FS code directly requires CRYPTO or CRYPTO_AES. These
options do get selected indirectly anyway via CEPH_LIB, which does need
them, but there is no need for CEPH_FS to select them too.
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
fs/ceph/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ceph/Kconfig b/fs/ceph/Kconfig
index 3e7def3d31c1..01a3e9a3a4fe 100644
--- a/fs/ceph/Kconfig
+++ b/fs/ceph/Kconfig
@@ -2,12 +2,10 @@
config CEPH_FS
tristate "Ceph distributed file system"
depends on INET
select CEPH_LIB
select CRC32
- select CRYPTO_AES
- select CRYPTO
select NETFS_SUPPORT
select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
default n
help
Choose Y or M here to include support for mounting the
base-commit: b2c27842ba853508b0da00187a7508eb3a96c8f7
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ceph: stop selecting CRYPTO and CRYPTO_AES
2025-12-04 6:11 [PATCH] ceph: stop selecting CRYPTO and CRYPTO_AES Eric Biggers
@ 2025-12-04 16:10 ` Ilya Dryomov
2025-12-05 6:48 ` Eric Biggers
0 siblings, 1 reply; 3+ messages in thread
From: Ilya Dryomov @ 2025-12-04 16:10 UTC (permalink / raw)
To: Eric Biggers; +Cc: Xiubo Li, ceph-devel
On Thu, Dec 4, 2025 at 7:13 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> None of the CEPH_FS code directly requires CRYPTO or CRYPTO_AES. These
> options do get selected indirectly anyway via CEPH_LIB, which does need
> them, but there is no need for CEPH_FS to select them too.
Hi Eric,
I think the same goes for CRC32. Would you mind covering it in your
patch?
Thanks,
Ilya
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> fs/ceph/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ceph/Kconfig b/fs/ceph/Kconfig
> index 3e7def3d31c1..01a3e9a3a4fe 100644
> --- a/fs/ceph/Kconfig
> +++ b/fs/ceph/Kconfig
> @@ -2,12 +2,10 @@
> config CEPH_FS
> tristate "Ceph distributed file system"
> depends on INET
> select CEPH_LIB
> select CRC32
> - select CRYPTO_AES
> - select CRYPTO
> select NETFS_SUPPORT
> select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
> default n
> help
> Choose Y or M here to include support for mounting the
>
> base-commit: b2c27842ba853508b0da00187a7508eb3a96c8f7
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ceph: stop selecting CRYPTO and CRYPTO_AES
2025-12-04 16:10 ` Ilya Dryomov
@ 2025-12-05 6:48 ` Eric Biggers
0 siblings, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2025-12-05 6:48 UTC (permalink / raw)
To: Ilya Dryomov; +Cc: Xiubo Li, ceph-devel
On Thu, Dec 04, 2025 at 05:10:28PM +0100, Ilya Dryomov wrote:
> On Thu, Dec 4, 2025 at 7:13 AM Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > None of the CEPH_FS code directly requires CRYPTO or CRYPTO_AES. These
> > options do get selected indirectly anyway via CEPH_LIB, which does need
> > them, but there is no need for CEPH_FS to select them too.
>
> Hi Eric,
>
> I think the same goes for CRC32. Would you mind covering it in your
> patch?
Good catch, I'll add that. Thanks.
- Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-05 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 6:11 [PATCH] ceph: stop selecting CRYPTO and CRYPTO_AES Eric Biggers
2025-12-04 16:10 ` Ilya Dryomov
2025-12-05 6:48 ` Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox