From: Sam Edwards <cfsworks@gmail.com>
To: Xiubo Li <xiubli@redhat.com>, Ilya Dryomov <idryomov@gmail.com>
Cc: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>,
Christian Brauner <brauner@kernel.org>,
Milind Changire <mchangir@redhat.com>,
Jeff Layton <jlayton@kernel.org>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Sam Edwards <CFSworks@gmail.com>
Subject: [PATCH 0/2] ceph: Properly clean up after failures in ceph_submit_write()
Date: Sun, 25 Jan 2026 18:27:13 -0800 [thread overview]
Message-ID: <20260126022715.404984-1-CFSworks@gmail.com> (raw)
Hi list,
This series contains two patches from my previous series [1] that are
independent and have no outstanding review comments.
The patches fix a crash that can occur if ceph_inc_osd_stopping_blocker()
fails on write, and split out the complex page-array cleanup logic to a new
helper function (per Slava's suggestion). The first patch is intended for
stable.
There is no known reproducer for this race condition; it appears to be
timing-sensitive. I have a fault-injection patch that can trigger it, which I
can provide on request.
Warm regards,
Sam
[1] https://lore.kernel.org/all/20260107210139.40554-1-CFSworks@gmail.com/
Sam Edwards (2):
ceph: free page array when ceph_submit_write() fails
ceph: split out page-array discarding to a function
fs/ceph/addr.c | 59 ++++++++++++++++++++++++++++++++------------------
1 file changed, 38 insertions(+), 21 deletions(-)
--
2.52.0
next reply other threads:[~2026-01-26 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 2:27 Sam Edwards [this message]
2026-01-26 2:27 ` [PATCH 1/2] ceph: free page array when ceph_submit_write() fails Sam Edwards
2026-01-26 22:51 ` Viacheslav Dubeyko
2026-01-29 0:10 ` Sam Edwards
2026-02-11 14:10 ` Ilya Dryomov
2026-02-11 14:52 ` Ilya Dryomov
2026-01-26 2:27 ` [PATCH 2/2] ceph: split out page-array discarding to a function Sam Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126022715.404984-1-CFSworks@gmail.com \
--to=cfsworks@gmail.com \
--cc=Slava.Dubeyko@ibm.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchangir@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox