CEPH filesystem development
 help / color / mirror / Atom feed
From: deepakroag <gaikwad.dcg@gmail.com>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: ceph-devel@vger.kernel.org, Ilya Dryomov <idryomov@gmail.com>,
	Alex Markuze <amarkuze@redhat.com>
Subject: Re: [PATCH 4/4] fix: release unused ceph cap reservation on readdir error
Date: Wed, 15 Jul 2026 23:46:25 +0530	[thread overview]
Message-ID: <20260715181625.18677-1-gaikwad.dcg@gmail.com> (raw)
In-Reply-To: <00fbda82bd63f3c7560898531b97a1b061fa6e2b.camel@dubeyko.com>

Hi Slava,

Sorry for the confusing [PATCH 4/4] subject — that was my mistake, not an intentional ceph patch series.

What happened: I batched four unrelated commits into one git send-email range. format-patch numbered them 1/4 through 4/4, but get_maintainer.pl routed each patch only to its subsystem list. ceph-devel received only patch 4.

This is a standalone one-patch fix for ceph. I have resent it as [PATCH 1/1] to ceph-devel in a separate thread.

The bug: in ceph_readdir_prepopulate(), ceph_fill_inode() consumes caps from req->r_caps_reservation. On error paths, unused caps were not returned to the MDS client pool (there is a FIXME: "release caps/leases if error occurs"). On success, ceph_unreserve_caps() is called in mds_client.c; on error it was skipped. The fix calls ceph_unreserve_caps() at out: when err != 0.

How I found it: code review while reading fs/ceph/inode.c — not a live Ceph cluster repro. Compiled fs/ceph/inode.o locally.

Thanks,
Deepak Rao Gaikwad

  parent reply	other threads:[~2026-07-15 18:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260715143646.15828-1-gaikwad.dcg@gmail.com>
2026-07-15 14:36 ` [PATCH 4/4] ceph: release unused cap reservation on readdir error deepakraog
2026-07-15 17:51   ` Viacheslav Dubeyko
2026-07-15 18:16     ` [PATCH] fix: release unused ceph " deepakroag
2026-07-16 17:24       ` Viacheslav Dubeyko
2026-07-15 18:16     ` deepakroag [this message]
2026-07-15 18:26       ` [PATCH 4/4] " deepakroag

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260715181625.18677-1-gaikwad.dcg@gmail.com \
    --to=gaikwad.dcg@gmail.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox