From: Alex Markuze <amarkuze@redhat.com>
To: max.kellermann@ionos.com
Cc: ceph-devel@vger.kernel.org
Subject: Re: ceph: don't unregister an MDS session before removing its caps
Date: Thu, 20 Aug 2026 07:23:23 +0000 [thread overview]
Message-ID: <20260820072323.2180183-1-amarkuze@redhat.com> (raw)
In-Reply-To: <20260818165053.3514195-1-max.kellermann@ionos.com>
Hi Max,
Deferring unregister until after remove_session_caps() is the right fix
for the BUG_ON. One gap though: check_new_map() wasn't updated for the
new invariant. A CLOSED session now stays in mdsc->sessions[], but that
loop still treats a registered session as live — on a rank failover it
can overwrite CLOSED with RESTARTING and call send_mds_reconnect() on a
dying object, or in the export-target path treat the occupied slot as
"no session" and fail to open a replacement.
The fix: in check_new_map(), skip CLOSED sessions the same way you skip
NULL slots.
Could you respin?
--
Alex Markuze
prev parent reply other threads:[~2026-08-20 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 16:50 [PATCH] ceph: don't unregister an MDS session before removing its caps Max Kellermann
2026-08-20 7:23 ` Alex Markuze [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820072323.2180183-1-amarkuze@redhat.com \
--to=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox