From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85440445ADD for ; Thu, 27 Aug 2026 13:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787838203; cv=none; b=JTI85MN34YyzxQES04N4/KSA/rFMIIeulHuksjPHXKiDgOKJsihS4enhl1CVCpEv/Dk/+5rURRs1GjS6RJRBQKLr2OOdU2hY28WcMC0Sptos3xY4mguKgQpFP0+yx9HOsu2FuBy0oBJo78VRY02dJ283dQoBw3ebwO1uh8tRmSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787838203; c=relaxed/simple; bh=WttVIq9XjP5ZXPUEj6UALIcW0XS1KIqNCyQ+upAILyk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Mt4FW+1KLlM3FJxSJ++waP5F8V4aAUSw0wVuD8ZkzNEbBlApgqgCPrxEm4DtwTp5DMvgmbC2aKAQ6vO+LqNOf5jtLCqBG+DiMxYyTSeT2EPtpQSPVtgJLRtlf4FGBh1oZOvsoLFHjGv1M6UMq+JPCCnN+giJn3bjlOsfEza0SA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q77rAEff; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q77rAEff" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787838200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eQpIcIRUXMJkur5fRP9zMSJz+yTJZukne+XmvkWNAbY=; b=Q77rAEffuGeqKtWISRSFoo9i1pvYGkF0sGWCKjqQPgdH1NAtr8ltLG7edYGjYyo+ccI1nk 6tGUChLEA67hH4/O9MjsNO9Zg+h6K1963syxps2c300rTsqL7X8e/xMPur4hplGSVZl+/U u9V30MIWBWBWauQFjQyado7mc/stmZ8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-yso55D_bPBiFFf1hi_ivtA-1; Thu, 27 Aug 2026 09:43:16 -0400 X-MC-Unique: yso55D_bPBiFFf1hi_ivtA-1 X-Mimecast-MFC-AGG-ID: yso55D_bPBiFFf1hi_ivtA_1787838193 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1800918011FC; Thu, 27 Aug 2026 13:43:12 +0000 (UTC) Received: from warthog.com (unknown [10.22.88.47]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C8FAB7D5; Thu, 27 Aug 2026 13:43:08 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Paulo Alcantara , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 00/10] netfs, cachefiles: Miscellaneous fixes Date: Thu, 27 Aug 2026 14:42:53 +0100 Message-ID: <20260827134304.2075713-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Hi Christian, Here are some miscellaneous fixes for netfslib and one for cachefiles, if you could pick them up? The first six are all in unbuffered/DIO write: (1) Fix an uninitialised return value from netfs_unbuffered_write(). (2) Fix the normal error return, preferring partial transfer size over request error over immediate error (e.g. EINTR). (3) Fix the async error return, preferring partial transfer size over error. (4) Fix the update of i_size on partial transfer ending in an error. (5) Fix a subrequest leak in an error path. (6) Fix the code to handle subrequest allocation failure. Then there's: (7) Fix synchronisation issues with using a progressive rolling buffer for readahead by fetching everything into it upfront so that the issues don't arise. Dropping the refs so acquired is deferred until after I/O is begun. (8) Change the marking of folios to be copied to the cache to be done whilst subreqs are being issued rather than at the time they're collected. Whilst this is not strictly a fix, it means that the collector thread doesn't need to try and keep track of that, which means that delayed progress reporting will not be a problem in patch (9). (9) Fix read progress reporting to avoid 64-bit tearing on a 32-bit machine. This has been modified from the previous submission as part of a different series to take account of a sashiko reported issue[1]. (10) Fix a potential UAF/KASAN warning reported by sashiko[1] in cachefiles in which the coherency data buffer is cast to a __be64* and dereferenced in a tracepoint - even though it might not be at least that large (or aligned). The patches can also be found here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes Thanks, David Changes ======= ver #4) - Fixed a number of issues reported by Sashiko[4]: - Fixed netfs_mark_copy_to_cache() to decrement len to end the loop. - Fixed netfs_read_to_pagecache() to init offset. - Fixed netfs_unlock_abandoned_read_pages() to clean up copy mark. - Fixed netfs_unlock_read_folio() to clean up copy mark. - Fixed copy-to-cache cancellation handling in netfs_unlock_read_folio(). - Removed duplicate var init in netfs_read_unlock_folios(). - Fixed setting of rreq->progress_at to ULONG_MAX (set to rreq->len instead). ver #3) - Fixed a number of issues reported by Sashiko[3]: - Fixed netfs_unbuffered_write() to return -ENOMEM to async writes too. - Added a patch to preload the entire readahead folio collection up front to avoid producer-consumer synchronisation issues. - Added a patch to premark buffered read folios with whether or not they're going to require caching so that the read-progress fix works correctly. ver #2) - Imported a patch to add subreq alloc failure handling in unbuffered/DIO write. - Fixed a number of issues reported by Sashiko[2]: - Added four patches to fix bugs in unbuffered/DIO write. - Added a patch to fix readahead rolling buffer issues. - Fixed the cachefiles xattr stuff to use max() not min() when allocating. - Fixed the cachefiles trace comment with regard to alignment. - Fixed netfs_read_set_unlock_at() to use folioq_count(), not folio_nr_slots(). [1] https://sashiko.dev/#/patchset/20260810144746.574036-1-dhowells%40redhat.com [2] https://sashiko.dev/#/patchset/20260824120224.504575-1-dhowells%40redhat.com [3] https://sashiko.dev/#/patchset/20260825132045.1000787-1-dhowells%40redhat.com [4] https://sashiko.dev/#/patchset/20260827093828.1956211-1-dhowells%40redhat.com David Howells (8): netfs: Fix unbuffered/DIO write partial transfer error return netfs: Fix error vs transferred passed to ->ki_complete() netfs: Fix i_size update for partial transfer netfs: Fix subreq ref leak netfs: Fix readahead synchronisation issues by loading all folios upfront netfs: Mark folios with COPY_TO_CACHE whilst issuing subreqs netfs: Fix read progress reporting cachefiles: Fix potential UAF/KASAN warning Edward Adam Davis (1): netfs: break unbuffered write when netfs_alloc_subrequest() fails Karl Mehltretter (1): netfs: Fix uninitialized return value in netfs_unbuffered_write() fs/cachefiles/xattr.c | 16 +-- fs/netfs/buffered_read.c | 164 ++++++++++++++++++++++-------- fs/netfs/direct_write.c | 31 ++++-- fs/netfs/internal.h | 3 + fs/netfs/misc.c | 19 ++++ fs/netfs/objects.c | 32 +++--- fs/netfs/read_collect.c | 128 ++++++++++++++++------- fs/netfs/read_pgpriv2.c | 15 +-- fs/netfs/read_retry.c | 13 ++- fs/netfs/read_single.c | 2 + fs/netfs/rolling_buffer.c | 81 +++++++++------ fs/netfs/write_issue.c | 2 + include/linux/netfs.h | 5 +- include/linux/rolling_buffer.h | 6 +- include/trace/events/cachefiles.h | 19 +++- include/trace/events/netfs.h | 30 +++++- 16 files changed, 411 insertions(+), 155 deletions(-)