From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Penyaev Subject: Re: [PATCH] libceph: fix alloc_msg_with_page_vector() memory leaks Date: Wed, 11 Mar 2020 11:28:18 +0100 Message-ID: <285a12636f1d70c09ae4e9b04b7dd3c7@suse.de> References: <20200310195037.9518-1-idryomov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:40716 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgCKK2U (ORCPT ); Wed, 11 Mar 2020 06:28:20 -0400 In-Reply-To: <20200310195037.9518-1-idryomov@gmail.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Ilya Dryomov Cc: ceph-devel@vger.kernel.org On 2020-03-10 20:50, Ilya Dryomov wrote: [skip] > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c > index 51810db4130a..998e26b75a78 100644 > --- a/net/ceph/osd_client.c > +++ b/net/ceph/osd_client.c > @@ -962,7 +962,7 @@ static void ceph_osdc_msg_data_add(struct ceph_msg > *msg, > BUG_ON(length > (u64) SIZE_MAX); > if (length) > ceph_msg_data_add_pages(msg, osd_data->pages, > - length, osd_data->alignment); > + length, osd_data->alignment, false); Now I got the point when you were saying "that would break OSDs which supply its own page vector". The callers of ceph_osdc_msg_data_add() always own the pages, understood. If necessary Reviewed-by: Roman Penyaev -- Roman