From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B523EC83F10 for ; Mon, 28 Aug 2023 01:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbjH1BUa (ORCPT ); Sun, 27 Aug 2023 21:20:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjH1BT6 (ORCPT ); Sun, 27 Aug 2023 21:19:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5150112A for ; Sun, 27 Aug 2023 18:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693185550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/wFdUhBYiorLNxPNX9d+o/zR7/OUp2COeFx2CRBT114=; b=HQOyctVdgrCUqxBb4VlSutNPciIFZpw/gF3Pg1MJNZK5xcVgEvkMcilhrT/oK+vSA5C6BR D+dh5ntyXH0GMLiMTmEAK4Fo4mOOgN5YvIKUSA54ledKH3+dLIEzIdb9K02ajOKMjF4Jfm Sdxm6qnKljuM1VvWoNMsunQtxAepblU= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-534-FnRB7f28Phim5QKq56Yx-Q-1; Sun, 27 Aug 2023 21:19:08 -0400 X-MC-Unique: FnRB7f28Phim5QKq56Yx-Q-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-68bf123aca4so2249143b3a.1 for ; Sun, 27 Aug 2023 18:19:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693185547; x=1693790347; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/wFdUhBYiorLNxPNX9d+o/zR7/OUp2COeFx2CRBT114=; b=goUb2NpDngrCAKPLmRvkb4LMxaG78WMNgohaa3dyJiWO1gmfuzmWCXFADnkNnlAtnG Fzc4IO7NRxtjtDEa9zMZ+0vfibAqfOGFoOVDSMxNyHWA6fMD4ILHh6plPcuNoZGtTO/j dk4yOlCfhHynyKkSi/e2tHBOKoGFjMlITL+jnuXV1I8LEWyoi4z387DScgGx6UUo8IKZ xLarxTrGrPKt1SQiweIsmQoRoKBPMWm3Yg+rbwOaW5Hq3g2T5LRRrEQTQGjFg6RPtaez fQAhLHO40ZFdSXTLvu68e6XXAAsE7+Q5ZmUYssOvqUk0cxP/nNG388oUlJFpWFX/uuzq J2NQ== X-Gm-Message-State: AOJu0YxSYl/UFMIcpvSgENjyl3UICL0lCRPfx3O9TyEPb9054goKG6pJ m7L3kRwd2DRjeXih6s0idbytgNIFrU9ZwhwvJFdL9WO3p2UldV3FpuvlEMqtIUkaPbK1ocVj0Uo tA8ixdjgY+7zPFJTVVyMXww== X-Received: by 2002:a05:6a20:8f28:b0:14c:d0c0:d4f8 with SMTP id b40-20020a056a208f2800b0014cd0c0d4f8mr3437833pzk.33.1693185547190; Sun, 27 Aug 2023 18:19:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSA0kB06YJcBI+5dbAzpb9/aRJNA24KHg/SWSWSst0JOhseoXN14tBLCXMMLz9M+yc0Rb8Uw== X-Received: by 2002:a05:6a20:8f28:b0:14c:d0c0:d4f8 with SMTP id b40-20020a056a208f2800b0014cd0c0d4f8mr3437824pzk.33.1693185546912; Sun, 27 Aug 2023 18:19:06 -0700 (PDT) Received: from [10.72.112.71] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id b1-20020a170902d50100b001adf6b21c77sm5898584plg.107.2023.08.27.18.19.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Aug 2023 18:19:06 -0700 (PDT) Message-ID: <2f1e16e5-1034-b064-7a92-e89f08fd2ac1@redhat.com> Date: Mon, 28 Aug 2023 09:19:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Xiubo Li Subject: Re: [PATCH 09/15] ceph: Use a folio in ceph_filemap_fault() To: Matthew Wilcox , Ilya Dryomov Cc: Jeff Layton , ceph-devel@vger.kernel.org, David Howells , linux-fsdevel@vger.kernel.org References: <20230825201225.348148-1-willy@infradead.org> <20230825201225.348148-10-willy@infradead.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On 8/26/23 11:00, Matthew Wilcox wrote: > On Fri, Aug 25, 2023 at 09:12:19PM +0100, Matthew Wilcox (Oracle) wrote: >> +++ b/fs/ceph/addr.c >> @@ -1608,29 +1608,30 @@ static vm_fault_t ceph_filemap_fault(struct vm_fault *vmf) >> ret = VM_FAULT_SIGBUS; >> } else { >> struct address_space *mapping = inode->i_mapping; >> - struct page *page; >> + struct folio *folio; >> >> filemap_invalidate_lock_shared(mapping); >> - page = find_or_create_page(mapping, 0, >> + folio = __filemap_get_folio(mapping, 0, >> + FGP_LOCK|FGP_ACCESSED|FGP_CREAT, >> mapping_gfp_constraint(mapping, ~__GFP_FS)); >> - if (!page) { >> + if (!folio) { > This needs to be "if (IS_ERR(folio))". Meant to fix that but forgot. > Hi Matthew, Next time please rebase to the latest ceph-client latest upstream 'testing' branch, we need to test this series by using the qa teuthology, which is running based on the 'testing' branch. Thanks - Xiubo