From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
"ethan198912@gmail.com" <ethan198912@gmail.com>
Cc: Xiubo Li <xiubli@redhat.com>,
"idryomov@gmail.com" <idryomov@gmail.com>,
Pavan Rallabhandi <Pavan.Rallabhandi@ibm.com>,
"ethanwu@synology.com" <ethanwu@synology.com>
Subject: Re: [PATCH] ceph: fix missing snapshot context in write operations
Date: Wed, 24 Sep 2025 18:05:50 +0000 [thread overview]
Message-ID: <433efdc7ddfabb7f1dfb798ef2ac496603f5c3a0.camel@ibm.com> (raw)
In-Reply-To: <20250924095807.27471-1-ethanwu@synology.com>
On Wed, 2025-09-24 at 17:58 +0800, ethanwu wrote:
> This series addresses two instances where Ceph filesystem operations
> were missing proper snapshot context handling, which could lead to
> data inconsistencies in snapshots.
>
It doesn't look like series. You can prepare patch set by using command:
git format-patch --cover-letter -2 HEAD
Thanks,
Slava.
> The issue occurs in two scenarios:
> 1. ceph_zero_partial_object() during fallocate punch hole operations
> 2. ceph_uninline_data() when converting inline data to regular objects
>
> Both functions were passing NULL snapshot context to OSD write operations
> instead of acquiring the appropriate context from either pending cap snaps
> or the inode's head snapc. This could result in snapshot data corruption
> where subsequent reads from snapshots would return modified data instead
> of the original snapshot content.
>
> The fix ensures that proper snapshot context is acquired and passed to
> all OSD write operations in these code paths.
>
> ethanwu (2):
> ceph: fix snapshot context missing in ceph_zero_partial_object
> ceph: fix snapshot context missing in ceph_uninline_data
>
> fs/ceph/addr.c | 19 +++++++++++++++++--
> fs/ceph/file.c | 17 ++++++++++++++++-
> 2 files changed, 33 insertions(+), 3 deletions(-)
prev parent reply other threads:[~2025-09-24 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 9:58 [PATCH] ceph: fix missing snapshot context in write operations ethanwu
2025-09-24 9:58 ` [PATCH] ceph: fix snapshot context missing in ceph_zero_partial_object ethanwu
2025-09-24 18:26 ` Viacheslav Dubeyko
2025-09-25 10:24 ` tzuchieh wu
2025-09-25 19:31 ` Viacheslav Dubeyko
2025-09-24 9:58 ` [PATCH] ceph: fix snapshot context missing in ceph_uninline_data ethanwu
2025-09-24 18:32 ` Viacheslav Dubeyko
2025-09-24 18:05 ` Viacheslav Dubeyko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433efdc7ddfabb7f1dfb798ef2ac496603f5c3a0.camel@ibm.com \
--to=slava.dubeyko@ibm.com \
--cc=Pavan.Rallabhandi@ibm.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ethan198912@gmail.com \
--cc=ethanwu@synology.com \
--cc=idryomov@gmail.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).