Re: [PATCH] ceph: remove the incorrect caps check in _file_size()

[Xiubo Li <xiubli@redhat.com>]

On 9/6/23 22:45, Greg KH wrote:
> On Wed, Sep 06, 2023 at 08:17:47PM +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> When truncating the inode the MDS will acquire the xlock for the
>> ifile Locker, which will revoke the 'Frwsxl' caps from the clients.
>> But when the client just releases and flushes the 'Fw' caps to MDS,
>> for exmaple, and once the MDS receives the caps flushing msg it
>> just thought the revocation has finished. Then the MDS will continue
>> truncating the inode and then issued the truncate notification to
>> all the clients. While just before the clients receives the cap
>> flushing ack they receive the truncation notification, the clients
>> will detecte that the 'issued | dirty' is still holding the 'Fw'
>> caps.
>>
>> Cc: stable@vger.kernel.org
>> URL: https://tracker.ceph.com/issues/56693
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>>   fs/ceph/inode.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
> What commit id does this fix?

Oh, I forgot to mention that in the commit comment, it will fix:

b0d7c2231015 ceph: introduce i_truncate_mutex

Let me update the patch and send out the V2 for it.

Thanks

- Xiubo



> thanks,
>
> greg k-h
>