From: "Jim Schutt" <jaschut@sandia.gov>
To: Tommi Virtanen <tommi.virtanen@dreamhost.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] ceph_common.sh: Do not sudo to root unless needed
Date: Mon, 19 Sep 2011 11:12:54 -0600 [thread overview]
Message-ID: <4E777816.3080206@sandia.gov> (raw)
In-Reply-To: <CAORUGqDgHS0z40=_Szp-N5ToLLdR3TT2Gdhm=WSN8Cr7-=jxyg@mail.gmail.com>
Tommi Virtanen wrote:
> On Wed, Sep 14, 2011 at 08:09, Jim Schutt <jaschut@sandia.gov> wrote:
>> Using do_root_cmd() doesn't really need to sudo to root
>> if you're already root.
>>
>> Commit 71dc75bdafe62a098c0493ad62f2d0d2a6ca7946 causes a regression:
>> when system "foo" has a sudoers config that requires a tty,
>> init-ceph now fails like this:
>> sudo: sorry, you must have a tty to run sudo
>>
>> when it is invoked by root with something like this:
>> ssh foo /etc/init.d/init-ceph start
>>
>> Signed-off-by: Jim Schutt <jaschut@sandia.gov>
>
> Applied as d64237a6a555944d6d35676490bc4fb7c7db965d, thank you.
>
> (It seems I screwed up the author field in the commit, sorry about
> that. I don't want to force push just to fix that; Signed-off-by gives
> you credit anyway.)
>
>
No problem - thanks for taking a look.
-- Jim
prev parent reply other threads:[~2011-09-19 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 15:09 [PATCH] ceph_common.sh: Do not sudo to root unless needed Jim Schutt
2011-09-19 16:49 ` Tommi Virtanen
2011-09-19 17:12 ` Jim Schutt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E777816.3080206@sandia.gov \
--to=jaschut@sandia.gov \
--cc=ceph-devel@vger.kernel.org \
--cc=tommi.virtanen@dreamhost.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox