From: Alex Elder <elder@dreamhost.com>
To: Sage Weil <sage@newdream.net>
Cc: Xi Wang <xi.wang@gmail.com>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] ceph: fix bounds check macros ceph_decode_need and ceph_encode_need
Date: Wed, 18 Apr 2012 13:41:23 -0500 [thread overview]
Message-ID: <4F8F0AD3.2030403@dreamhost.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1204181052530.15730@cobra.newdream.net>
On 04/18/2012 12:53 PM, Sage Weil wrote:
> Would something like ceph_has_room() make more sense?
Yes, and standing by itself it reads a lot better too.
The "need_ok" came from the fact that it was only ever
called by ceph_need_*() macros.
Without objection I'll change it to ceph_has_room()
before I commit it for testing.
-Alex
next prev parent reply other threads:[~2012-04-18 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 20:24 [PATCH 0/3] ceph: fix multiple out-of-bounds checks Xi Wang
2011-12-14 20:24 ` [PATCH 1/3] ceph: fix out-of-bounds pointers in parse_reply_info() Xi Wang
2011-12-14 20:24 ` [PATCH 2/3] ceph: fix bounds check macros ceph_decode_need and ceph_encode_need Xi Wang
2012-04-18 14:13 ` Alex Elder
2012-04-18 17:53 ` Sage Weil
2012-04-18 18:41 ` Alex Elder [this message]
2011-12-14 20:24 ` [PATCH 3/3] ceph: avoid panic with mismatched symbolic link sizes in fill_inode() Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F0AD3.2030403@dreamhost.com \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox