Re: global_init_daemonize: BUG: there are 1 child threads already started that will now die!

[Josh Durgin <josh.durgin@inktank.com>]

On 05/17/2012 04:53 AM, Székelyi Szabolcs wrote:
> Hello,
>
> I get the $subject message when starting Ceph with the init script. I have to
> try it 15-20 times until the start suceeds. I've seen this message emitted by
> the monitor and MDS daemons, but never by OSDs. Is this really a bug as the
> message says? I have two theoretically identical clusters, and only one of
> them produces this error, so something might be wrong on my side, but what?
>
> Thanks,

This was a kludgy check that was accidentally getting triggered after 
some logging code changes. It was removed by:

commit 2629474f521f5cf67ccb8d09c289e1424c9e07ec
Author: Sage Weil <sage.weil@dreamhost.com>
Date:   Thu May 3 18:50:42 2012 -0700

global_init: do not count threads before daemonize()

We were verifying that there was only 1 thread (the presumably main()) when
we call daemonize.  However, with the new logging code, we stop a thread
right before the check, and /proc apparently updates asynchronously such
that our attempt to count running threads gives us a bad answer.

Just remove this kludgey check; we'll have to catch this class of bugs
the hard way.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html