From: Alex Elder <elder@dreamhost.com>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] rbd: Fix ceph_snap_context size calculation
Date: Mon, 04 Jun 2012 15:08:12 -0500 [thread overview]
Message-ID: <4FCD15AC.5080606@dreamhost.com> (raw)
In-Reply-To: <1338797469-23314-1-git-send-email-zheng.z.yan@intel.com>
On 06/04/2012 03:11 AM, Yan, Zheng wrote:
> From: "Yan, Zheng"<zheng.z.yan@intel.com>
>
> ceph_snap_context->snaps is an u64 array
You are correct. We'll get this in soon. Thanks.
Reviewed-by: Alex Elder <elder@inktank.com>
> Signed-off-by: Zheng Yan<zheng.z.yan@intel.com>
> ---
> drivers/block/rbd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 65665c9..8b9c173 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -499,7 +499,7 @@ static int rbd_header_from_disk(struct rbd_image_header *header,
> / sizeof (*ondisk))
> return -EINVAL;
> header->snapc = kmalloc(sizeof(struct ceph_snap_context) +
> - snap_count * sizeof (*ondisk),
> + snap_count * sizeof(u64),
> gfp_flags);
> if (!header->snapc)
> return -ENOMEM;
prev parent reply other threads:[~2012-06-04 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 8:11 [PATCH] rbd: Fix ceph_snap_context size calculation Yan, Zheng
2012-06-04 20:08 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD15AC.5080606@dreamhost.com \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox