From: Alex Elder <elder@inktank.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 2/2] libceph: drop connection refcounting for mon_client
Date: Tue, 05 Jun 2012 22:31:01 -0500 [thread overview]
Message-ID: <4FCECEF5.1040802@inktank.com> (raw)
In-Reply-To: <4FCECD7F.9030002@inktank.com>
From Sage Weil <sage@inktank.com>
All references to the embedded ceph_connection come from the msgr
workqueue, which is drained prior to mon_client destruction. That
means we can ignore con refcounting entirely.
Signed-off-by: Sage Weil <sage@newdream.net>
Reviewed-by: Alex Elder <elder@inktank.com>
---
net/ceph/mon_client.c | 18 ++++++++++++++++--
1 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/net/ceph/mon_client.c b/net/ceph/mon_client.c
index ac4d6b1..062b724 100644
--- a/net/ceph/mon_client.c
+++ b/net/ceph/mon_client.c
@@ -1029,9 +1029,23 @@ out:
mutex_unlock(&monc->mutex);
}
+/*
+ * We can ignore refcounting on the connection struct, as all references
+ * will come from the messenger workqueue, which is drained prior to
+ * mon_client destruction.
+ */
+static struct ceph_connection *con_get(struct ceph_connection *con)
+{
+ return con;
+}
+
+static void con_put(struct ceph_connection *con)
+{
+}
+
static const struct ceph_connection_operations mon_con_ops = {
- .get = ceph_con_get,
- .put = ceph_con_put,
+ .get = con_get,
+ .put = con_put,
.dispatch = dispatch,
.fault = mon_fault,
.alloc_msg = mon_alloc_msg,
--
1.7.5.4
next prev parent reply other threads:[~2012-06-06 3:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 3:24 [PATCH 00/11] continued messenger-related changes Alex Elder
2012-06-06 3:30 ` [PATCH] libceph: osd_client: don't drop reply reference too early Alex Elder
2012-06-06 16:18 ` Sage Weil
2012-06-06 3:30 ` [PATCH] libceph: use con get/put ops from osd_client Alex Elder
2012-06-06 3:30 ` [PATCH 1/2] libceph: embed ceph connection structure in mon_client Alex Elder
2012-06-06 5:22 ` Sage Weil
2012-06-06 16:19 ` Sage Weil
2012-06-06 3:31 ` Alex Elder [this message]
2012-06-06 3:31 ` [PATCH 1/2] libceph: init monitor connection when opening Alex Elder
2012-06-06 3:31 ` [PATCH 2/2] libceph: fully initialize connection in con_init() Alex Elder
2012-06-06 3:31 ` [PATCH] libceph: tweak ceph_alloc_msg() Alex Elder
2012-06-06 5:14 ` Sage Weil
2012-06-06 3:31 ` [PATCH 1/4] libceph: have messages point to their connection Alex Elder
2012-06-06 5:16 ` Sage Weil
2012-06-06 3:31 ` [PATCH 2/4] libceph: have messages take a connection reference Alex Elder
2012-06-06 17:06 ` Sage Weil
2012-06-06 17:34 ` Alex Elder
2012-06-06 3:31 ` [PATCH 3/4] libceph: make ceph_con_revoke() a msg operation Alex Elder
2012-06-06 5:18 ` Sage Weil
2012-06-06 11:51 ` Alex Elder
2012-06-06 3:31 ` [PATCH 4/4] libceph: make ceph_con_revoke_message() a msg op Alex Elder
2012-06-06 5:22 ` Sage Weil
2012-06-06 11:40 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCECEF5.1040802@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox