From: Alex Elder <elder@inktank.com>
To: ceph-devel <ceph-devel@vger.kernel.org>
Subject: [PATCH 1/6] rbd: skip getting image id if known
Date: Tue, 30 Oct 2012 20:49:04 -0500 [thread overview]
Message-ID: <50908390.5020607@inktank.com> (raw)
In-Reply-To: <509081C4.3050402@inktank.com>
We will know the image id for format 2 parent images, but won't
initially know its image name. Avoid making the query for an image
id in rbd_dev_image_id() if it's already known.
Signed-off-by: Alex Elder <elder@inktank.com>
---
drivers/block/rbd.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 8d26c0f..a852133 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -3068,6 +3068,14 @@ static int rbd_dev_image_id(struct rbd_device
*rbd_dev)
void *p;
/*
+ * When probing a parent image, the image id is already
+ * known (and the image name likely is not). There's no
+ * need to fetch the image id again in this case.
+ */
+ if (rbd_dev->spec->image_id)
+ return 0;
+
+ /*
* First, see if the format 2 image id file exists, and if
* so, get the image's persistent id from it.
*/
--
1.7.9.5
next prev parent reply other threads:[~2012-10-31 1:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 1:41 [PATCH 0/6] rbd: version 2 parent probing Alex Elder
2012-10-31 1:49 ` Alex Elder [this message]
2012-10-31 21:05 ` [PATCH 1/6] rbd: skip getting image id if known Josh Durgin
2012-10-31 1:49 ` [PATCH 2/6] rbd: allow null image name Alex Elder
2012-10-31 21:07 ` Josh Durgin
2012-10-31 1:49 ` [PATCH 3/6] rbd: get parent spec for version 2 images Alex Elder
2012-11-01 1:33 ` Josh Durgin
2012-10-31 1:49 ` [PATCH 4/6] libceph: define ceph_pg_pool_name_by_id() Alex Elder
2012-11-01 1:34 ` Josh Durgin
2012-10-31 1:49 ` [PATCH 5/6] rbd: get additional info in parent spec Alex Elder
2012-10-31 14:11 ` Alex Elder
2012-11-01 1:49 ` Josh Durgin
2012-11-01 12:18 ` Alex Elder
2012-10-31 1:50 ` [PATCH 6/6] rbd: probe the parent of an image if present Alex Elder
2012-10-31 11:59 ` slow fio random read benchmark, need help Alexandre DERUMIER
2012-10-31 15:57 ` Sage Weil
2012-10-31 16:29 ` Alexandre DERUMIER
2012-10-31 16:50 ` Alexandre DERUMIER
2012-10-31 17:08 ` Marcus Sorensen
2012-10-31 17:27 ` Alexandre DERUMIER
2012-10-31 17:38 ` Marcus Sorensen
2012-10-31 18:56 ` Alexandre DERUMIER
2012-10-31 19:50 ` Marcus Sorensen
2012-11-01 5:11 ` Alexandre DERUMIER
2012-11-01 5:41 ` Stefan Priebe - Profihost AG
2012-10-31 20:22 ` Josh Durgin
2012-11-01 7:38 ` Dietmar Maurer
2012-11-01 8:08 ` Stefan Priebe - Profihost AG
2012-11-01 10:40 ` Gregory Farnum
2012-11-01 10:54 ` Stefan Priebe - Profihost AG
2012-11-02 9:38 ` Alexandre DERUMIER
2012-11-03 10:01 ` slow fio random read benchmark: last librbd git : 20000iops ! Alexandre DERUMIER
2012-11-03 12:09 ` Alexandre DERUMIER
2012-11-01 15:46 ` slow fio random read benchmark, need help Marcus Sorensen
2012-11-01 16:28 ` Marcus Sorensen
2012-11-01 17:00 ` Dietmar Maurer
2012-11-03 17:09 ` Gregory Farnum
2012-11-04 14:54 ` Alexandre DERUMIER
2012-11-01 2:07 ` [PATCH 6/6] rbd: probe the parent of an image if present Josh Durgin
2012-11-01 12:26 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50908390.5020607@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox