Re: librbd discard bug problems -> i got it

[Josh Durgin <josh.durgin@inktank.com>]

On 11/19/2012 02:45 PM, Stefan Priebe wrote:
> Hi Josh,
>
> how can i log in AioRequest.h?
>
> I need to add some debugging into:
>      void complete(int r)
>      {
>        if (should_complete(r)) {
>          if (m_hide_enoent && r == -ENOENT)
>            r = 0;
>          m_completion->complete(r);
>          delete this;
>        }
>      }

Move the implementation of the method out of the header and into
AioRequest.cc. Then you can use ldout like in the rest of that file.

Josh

> Am 19.11.2012 23:38, schrieb Josh Durgin:
>> On 11/19/2012 01:19 PM, Stefan Priebe wrote:
>>> Hello Josh,
>>>
>>> after digging three days around i got it.
>>
>> That's great!
>>
>>> The problem is in aio_discard in internal.cc. The i/o fails when AioZero
>>> or AioTruncate is used.
>>
>> Interesting, I wouldn't have expected the bug to be there. Is
>> it failing with a different error code, or just taking too long
>> so the guest kernel tries to cancel it?
>>
>>> It works fine with AioRemove. It seems to depend on overlapping.
>>> Hopefully i'm able to provide a patch this nicht.
>>
>> Looking forward to it!
>>
>> Josh
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html