From: Stefan Priebe <s.priebe@profihost.ag>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@gmail.com,
ceph-devel@vger.kernel.org, pbonzini@redhat.com,
josh.durgin@inktank.com
Subject: Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel
Date: Sat, 24 Nov 2012 21:21:46 +0100 [thread overview]
Message-ID: <50B12C5A.5010804@profihost.ag> (raw)
In-Reply-To: <CAAu8pHti5JOzMcAK1P_3HrtxfpQgmeJA84CMRBAO9BF7-X2TEQ@mail.gmail.com>
Am 24.11.2012 20:54, schrieb Blue Swirl:
> On Thu, Nov 22, 2012 at 10:00 AM, Stefan Priebe <s.priebe@profihost.ag> wrote:
>> This one fixes a race which qemu had also in iscsi block driver
>> between cancellation and io completition.
>>
>> qemu_rbd_aio_cancel was not synchronously waiting for the end of
>> the command.
>>
>> To archieve this it introduces a new status flag which uses
>> -EINPROGRESS.
>>
>> Signed-off-by: Stefan Priebe <s.priebe@profihost.ag>
...
>>
>> - qemu_aio_release(acb);
>> + if (!acb->cancelled)
>
> Missing braces, please read CODING_STYLE.
Will fix this if the rest is OK. Waiting for Stefan and Paolo.
Stefan
next prev parent reply other threads:[~2012-11-24 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 10:00 [PATCH] rbd block driver fix race between aio completition and aio cancel Stefan Priebe
2012-11-24 19:54 ` [Qemu-devel] " Blue Swirl
2012-11-24 20:21 ` Stefan Priebe [this message]
2012-11-27 22:42 ` Josh Durgin
2012-11-29 15:24 ` Paolo Bonzini
2012-11-29 13:58 ` Stefan Hajnoczi
2012-11-29 14:32 ` Stefan Priebe - Profihost AG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B12C5A.5010804@profihost.ag \
--to=s.priebe@profihost.ag \
--cc=blauwirbel@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=josh.durgin@inktank.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox