CEPH filesystem development
 help / color / mirror / Atom feed
From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
To: ceph-devel@vger.kernel.org
Cc: Sage Weil <sage@inktank.com>
Subject: Re: [PATCH] fix syncfs handling in error case
Date: Tue, 27 Nov 2012 16:42:35 +0100	[thread overview]
Message-ID: <50B4DF6B.9090304@bisect.de> (raw)
In-Reply-To: <1354029799-14465-1-git-send-email-danny.al-gaaf@bisect.de>

Hi,

forget this patch, I'll send a new version due to changes in master.

Danny

Am 27.11.2012 16:23, schrieb Danny Al-Gaaf:
> If the call to syncfs() fails, don't try to call syncfs again via
> syscall(). If HAVE_SYS_SYNCFS is defined, don't use syscall() with
> SYS_syncfs.
> 
> Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
> ---
>  src/common/sync_filesystem.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/common/sync_filesystem.h b/src/common/sync_filesystem.h
> index dc90b89..976400f 100644
> --- a/src/common/sync_filesystem.h
> +++ b/src/common/sync_filesystem.h
> @@ -34,9 +34,7 @@ inline int sync_filesystem(int fd)
>  #ifdef HAVE_SYS_SYNCFS
>    if (syncfs(fd) == 0)
>      return 0;
> -#endif
> -
> -#ifdef SYS_syncfs
> +#elif defined(SYS_syncfs)
>    if (syscall(SYS_syncfs, fd) == 0)
>      return 0;
>  #endif
> 


  reply	other threads:[~2012-11-27 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 15:23 [PATCH] fix syncfs handling in error case Danny Al-Gaaf
2012-11-27 15:42 ` Danny Al-Gaaf [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-27 15:54 Danny Al-Gaaf
2012-11-27 16:53 ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B4DF6B.9090304@bisect.de \
    --to=danny.al-gaaf@bisect.de \
    --cc=ceph-devel@vger.kernel.org \
    --cc=sage@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox