From: Alex Elder <alex.elder@linaro.org>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: ceph-devel@vger.kernel.org, sage@inktank.com
Subject: Re: [PATCH 1/2] ceph: remove ceph_lookup_inode()
Date: Tue, 03 Sep 2013 08:40:31 -0500 [thread overview]
Message-ID: <5225E6CF.2060306@linaro.org> (raw)
In-Reply-To: <1378106394-14481-1-git-send-email-zheng.z.yan@intel.com>
On 09/02/2013 02:19 AM, Yan, Zheng wrote:
> From: "Yan, Zheng" <zheng.z.yan@intel.com>
>
> commit 6f60f889 (ceph: fix freeing inode vs removing session caps race)
> introduced ceph_lookup_inode(). But there is already a ceph_find_inode()
> which provides similar function. So remove ceph_lookup_inode(), use
> ceph_find_inode() instead.
>
> Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> fs/ceph/inode.c | 8 --------
> fs/ceph/mds_client.c | 2 +-
> fs/ceph/super.h | 2 --
> 3 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> index eae41cd..8549a48 100644
> --- a/fs/ceph/inode.c
> +++ b/fs/ceph/inode.c
> @@ -62,14 +62,6 @@ struct inode *ceph_get_inode(struct super_block *sb, struct ceph_vino vino)
> return inode;
> }
>
> -struct inode *ceph_lookup_inode(struct super_block *sb, struct ceph_vino vino)
> -{
> - struct inode *inode;
> - ino_t t = ceph_vino_to_ino(vino);
> - inode = ilookup5_nowait(sb, t, ceph_ino_compare, &vino);
> - return inode;
> -}
> -
> /*
> * get/constuct snapdir inode for a given directory
> */
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 603786b..b7bda5d 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -1054,7 +1054,7 @@ static void remove_session_caps(struct ceph_mds_session *session)
> vino = cap->ci->i_vino;
> spin_unlock(&session->s_cap_lock);
>
> - inode = ceph_lookup_inode(sb, vino);
> + inode = ceph_find_inode(sb, vino);
> iput(inode);
>
> spin_lock(&session->s_cap_lock);
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index bb23ef6..6014b0a 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -694,8 +694,6 @@ extern void ceph_destroy_inode(struct inode *inode);
>
> extern struct inode *ceph_get_inode(struct super_block *sb,
> struct ceph_vino vino);
> -extern struct inode *ceph_lookup_inode(struct super_block *sb,
> - struct ceph_vino vino);
> extern struct inode *ceph_get_snapdir(struct inode *parent);
> extern int ceph_fill_file_size(struct inode *inode, int issued,
> u32 truncate_seq, u64 truncate_size, u64 size);
>
prev parent reply other threads:[~2013-09-03 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 7:19 [PATCH 1/2] ceph: remove ceph_lookup_inode() Yan, Zheng
2013-09-02 7:19 ` [PATCH 2/2] ceph: use d_invalidate() to invalidate aliases Yan, Zheng
2013-09-03 13:48 ` Alex Elder
2013-09-03 13:40 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225E6CF.2060306@linaro.org \
--to=alex.elder@linaro.org \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@inktank.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox