* ghobjects: assert in FileStore::lfn_open
@ 2013-09-27 14:12 Loic Dachary
2013-10-07 20:14 ` Samuel Just
0 siblings, 1 reply; 2+ messages in thread
From: Loic Dachary @ 2013-09-27 14:12 UTC (permalink / raw)
To: David Zafman; +Cc: Ceph Development
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
Hi David,
In
int FileStore::lfn_open(coll_t cid,
const ghobject_t& oid,
bool create,
FDRef *outfd,
IndexedPath *path,
Index *index)
{
assert(get_allow_sharded_objects() || oid.shard_id == ghobject_t::NO_SHARD);
assert(outfd);
would it make sense to
assert(get_allow_sharded_objects() || ( oid.shard_id == ghobject_t::NO_SHARD) && oid.generation == ghobject_t::NO_GEN) )
instead ?
Cheers
--
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ghobjects: assert in FileStore::lfn_open
2013-09-27 14:12 ghobjects: assert in FileStore::lfn_open Loic Dachary
@ 2013-10-07 20:14 ` Samuel Just
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Just @ 2013-10-07 20:14 UTC (permalink / raw)
To: Loic Dachary; +Cc: David Zafman, Ceph Development
That sounds better to me, since the generation stuff triggers the same
format switch.
-Sam
On Fri, Sep 27, 2013 at 7:12 AM, Loic Dachary <loic@dachary.org> wrote:
> Hi David,
>
> In
>
> int FileStore::lfn_open(coll_t cid,
> const ghobject_t& oid,
> bool create,
> FDRef *outfd,
> IndexedPath *path,
> Index *index)
> {
> assert(get_allow_sharded_objects() || oid.shard_id == ghobject_t::NO_SHARD);
> assert(outfd);
>
> would it make sense to
>
> assert(get_allow_sharded_objects() || ( oid.shard_id == ghobject_t::NO_SHARD) && oid.generation == ghobject_t::NO_GEN) )
>
> instead ?
>
> Cheers
>
> --
> Loïc Dachary, Artisan Logiciel Libre
> All that is necessary for the triumph of evil is that good people do nothing.
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-07 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 14:12 ghobjects: assert in FileStore::lfn_open Loic Dachary
2013-10-07 20:14 ` Samuel Just
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).