From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <ilya.dryomov@inktank.com>, ceph-devel@vger.kernel.org
Cc: Yan Zheng <zheng.z.yan@intel.com>
Subject: Re: [PATCH] ceph: fix sizeof(struct tYpO *) typo
Date: Fri, 25 Jul 2014 07:52:32 -0500 [thread overview]
Message-ID: <53D25310.4090001@ieee.org> (raw)
In-Reply-To: <1406280385-30275-1-git-send-email-ilya.dryomov@inktank.com>
On 07/25/2014 04:26 AM, Ilya Dryomov wrote:
> struct ceph_xattr -> struct ceph_inode_xattr
Looks good. I can't find the definition of ceph_xattr.
Reviewed-by: Alex Elder <elder@linaro.org>
> Reported-by: Toralf Förster <toralf.foerster@gmx.de>
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
> ---
> fs/ceph/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
> index f89698cdbc41..12f58d22e017 100644
> --- a/fs/ceph/xattr.c
> +++ b/fs/ceph/xattr.c
> @@ -592,7 +592,7 @@ start:
> xattr_version = ci->i_xattrs.version;
> spin_unlock(&ci->i_ceph_lock);
>
> - xattrs = kcalloc(numattr, sizeof(struct ceph_xattr *),
> + xattrs = kcalloc(numattr, sizeof(struct ceph_inode_xattr *),
> GFP_NOFS);
> err = -ENOMEM;
> if (!xattrs)
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-25 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 9:26 [PATCH] ceph: fix sizeof(struct tYpO *) typo Ilya Dryomov
2014-07-25 12:52 ` Alex Elder [this message]
2014-07-25 13:27 ` Ilya Dryomov
2014-07-25 15:53 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D25310.4090001@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ilya.dryomov@inktank.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox