From: Ken Dreyer <kdreyer@redhat.com>
To: Owen Synge <osynge@suse.com>, Sage Weil <sweil@redhat.com>,
Loic Dachary <loic@dachary.org>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: what this would look like if the system is with templates.
Date: Tue, 09 Jun 2015 17:06:12 -0600 [thread overview]
Message-ID: <55777164.6090201@redhat.com> (raw)
In-Reply-To: <5577202D.2040007@suse.com>
On 06/09/2015 11:19 AM, Owen Synge wrote:
>
>> we can be remove many hard coded values replaced with variable and that
>> probably will only grow in number for example
>>
>> %if 0%{?rhel} || 0%{?fedora}
>> --with-systemd-libexec-dir=/usr/libexec/ceph \
>> %endif
>> %if 0%{?opensuse} || 0%{?suse_version}
>> --with-systemd-libexec-dir=/usr/lib/ceph/ \
>> %endif
>
> --with-systemd-libexec-dir=@systemd_libexec_dir@ \
>
> No OS distribution specific rubbish needed :)
Passing an autoconf variable (@systemd_libexec_dir@) to an autoconf
argument (--with-systemd-libexec-dir) seems really over-complicated to me.
I don't see the issues with putting os-specific things in the .spec
file; that's how many other (non-Ceph) projects do it.
- Ken
next prev parent reply other threads:[~2015-06-09 23:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 8:34 Configure dependencies can be the same as make dependencies Loic Dachary
2015-05-05 14:31 ` Gregory Farnum
2015-05-05 14:36 ` Loic Dachary
2015-05-05 18:59 ` Ken Dreyer
2015-05-05 19:07 ` Loic Dachary
2015-05-05 19:31 ` Sage Weil
2015-06-09 17:11 ` Owen Synge
2015-06-09 17:19 ` what this would look like if the system is with templates Owen Synge
2015-06-09 23:06 ` Ken Dreyer [this message]
2015-06-10 10:44 ` Owen Synge
2015-06-09 17:22 ` Configure dependencies can be the same as make dependencies Sage Weil
2015-06-09 18:23 ` Owen Synge
2015-06-09 18:44 ` Sage Weil
2015-06-09 19:23 ` Owen Synge
2015-05-05 17:15 ` Kefu Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55777164.6090201@redhat.com \
--to=kdreyer@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=loic@dachary.org \
--cc=osynge@suse.com \
--cc=sweil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox