CEPH filesystem development
 help / color / mirror / Atom feed
From: David Zafman <dzafman@redhat.com>
To: Wei-Chung Cheng <freeze.vicente.cheng@gmail.com>
Cc: Sage Weil <sage@newdream.net>,
	Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: OSD replacement feature
Date: Mon, 23 Nov 2015 23:26:40 -0800	[thread overview]
Message-ID: <56541130.6090005@redhat.com> (raw)
In-Reply-To: <CABF_e-EMtmQYANTMTcm5NP5-s1mPsHUXtrzXfeCMoHoV2LEELA@mail.gmail.com>


That is correct.  The goal is to only refill the replacement OSD disk.  
Otherwise, if the OSD is only down for less than 
mon_osd_down_out_interval (5 min default) or noout is set, no other data 
movement would occur.

David

On 11/23/15 8:45 PM, Wei-Chung Cheng wrote:
> 2015-11-21 1:54 GMT+08:00 David Zafman <dzafman@redhat.com>:
>> There are two reasons for having a ceph-disk replace feature.
>>
>> 1. To simplify the steps required to replace a disk
>> 2. To allow a disk to be replaced proactively without causing any data
>> movement.
> Hi David,
>
> It good to without causing any data movement when we want to replaced
> failure osd.
>
> But I don't have any idea to complete it, could you give some opinions?
>
> I though if we want to replace failure we must move the object data on
> failure osd to new(replacement) osd?
>
> Or I got some misunderstanding?
>
> thanks!!!
> vicente
>
>> So keeping the osd id the same is required and is what motivated the feature
>> for me.
>>
>> David
>>
>>
>> On 11/20/15 3:38 AM, Sage Weil wrote:
>>> On Fri, 20 Nov 2015, Wei-Chung Cheng wrote:
>>>> Hi Loic and cephers,
>>>>
>>>> Sure, I have time to help (comment) on this feature replace a disk.
>>>> This is a useful feature to handle disk failure :p
>>>>
>>>> An simple step is described on http://tracker.ceph.com/issues/13732 :
>>>> 1. set noout flag - if the broken osd is primary osd, could we handle
>>>> well?
>>>> 2. stop osd daemon and we need to wait the osd actually down. (or
>>>> maybe use deactivate option with ceph-disk)
>>>>
>>>> these two above step seems OK.
>>>> about handle crush map, should we remove the broken osd out?
>>>> If we do that, why we set noout flag? It still trigger re-balance
>>>> after we remove osd from crushmap.
>>> Right--I think you generally want to do either one or the other:
>>>
>>> 1) mark osd out, leave failed disk in place.  or, replace with new disk
>>> that re-uses the same osd id.
>>>
>>> or,
>>>
>>> 2) remove osd from crush map.  replace with new disk (which gets new osd
>>> id).
>>>
>>> I think re-using the osd id is awkward currently, so doing 1 and replacing
>>> the disk ends up moving data twice.
>>>
>>> sage
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2015-11-24  7:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 17:20 OSD replacement feature Loic Dachary
2015-11-20  7:55 ` Wei-Chung Cheng
2015-11-20 11:38   ` Sage Weil
2015-11-20 16:40     ` Wei-Chung Cheng
2015-11-20 17:54     ` David Zafman
2015-11-24  4:45       ` Wei-Chung Cheng
2015-11-24  7:26         ` David Zafman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56541130.6090005@redhat.com \
    --to=dzafman@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=freeze.vicente.cheng@gmail.com \
    --cc=sage@newdream.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox