From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: block-rbd: One function call less in rbd_dev_probe_parent() after error detection Date: Wed, 25 Nov 2015 11:23:21 +0100 Message-ID: <56558C19.8090607@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <56536BAD.4000309@users.sourceforge.net> <56536D12.4000308@users.sourceforge.net> <5654B91D.4040808@users.sourceforge.net> <5654C9F2.20409@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ilya Dryomov Cc: Alex Elder , Sage Weil , Ceph Development , LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Dan Carpenter List-Id: ceph-devel.vger.kernel.org > "one err bug" as per CodingStyle is a NULL deref on line 2 if foo is NULL. > If it was just "err: kfree(foo); return ret;", a NULL foo would be perfectly OK. Would it make sense to rename such an issue as the "one error jump label bug"? https://plus.google.com/106378716002406849458/posts/dnanfhQ4mHQ Regards, Markus