From: Wido den Hollander <wido@42on.com>
To: Sage Weil <sage@newdream.net>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: Quering since when a PG is inactive
Date: Wed, 9 Dec 2015 17:14:21 +0100 [thread overview]
Message-ID: <5668535D.7050509@42on.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1512090549400.12816@cobra.newdream.net>
On 12/09/2015 02:50 PM, Sage Weil wrote:
> Hi Wido!
>
> On Wed, 9 Dec 2015, Wido den Hollander wrote:
>> Hi,
>>
>> I'm working on a patch in PGMonitor.cc that sets the state to HEALTH_ERR
>> if >= X PGs are stuck non-active.
>>
>> This works for me now, but I would like to add a timer that a PG has to
>> be inactive for more than Y seconds.
>>
>> The PGMap contains "last_active" and "last_clean", but these timestamps
>> are never updated. So I can't query for last_active =< (now() - 300) for
>> example.
>>
>> On a idle test cluster I have a PG for example:
>>
>> "last_active": "2015-12-09 02:32:31.540712",
>>
>> It's currently 08:53:56 here, so I can't check against last_active.
>>
>> What would a good way be to see for how long a PG has been inactive?
>
> It sounds like maybe the current code is subtley broken:
>
> https://github.com/ceph/ceph/blob/master/src/osd/PG.cc#L2566
>
> The last_active/clean etc should be fresh within
> osd_pg_stat_report_interval_max seconds...
>
Indeed, that seems broken. I created a issue for it:
http://tracker.ceph.com/issues/14028
I'm not sure where to start (yet).
> sage
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Wido den Hollander
42on B.V.
Ceph trainer and consultant
Phone: +31 (0)20 700 9902
Skype: contact42on
prev parent reply other threads:[~2015-12-09 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 7:54 Quering since when a PG is inactive Wido den Hollander
2015-12-09 13:50 ` Sage Weil
2015-12-09 16:14 ` Wido den Hollander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5668535D.7050509@42on.com \
--to=wido@42on.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox