CEPH filesystem development
 help / color / mirror / Atom feed
From: Loic Dachary <loic@dachary.org>
To: Sage Weil <sweil@redhat.com>, ceph-devel@vger.kernel.org
Subject: Re: cmake
Date: Wed, 16 Dec 2015 18:53:18 +0100	[thread overview]
Message-ID: <5671A50E.4060302@dachary.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1512160839350.10312@cobra.newdream.net>

[-- Attachment #1: Type: text/plain, Size: 2183 bytes --]

Hi,

On 16/12/2015 18:33, Sage Weil wrote:
> The work to transition to cmake has stalled somewhat.  I've tried to use 
> it a few times but keep running into issues that make it unusable for me.  
> Not having make check is a big one, but I think the hackery required to 
> get that going points to the underlying problem(s).
> 
> I seems like the main problem is that automake puts all build targets in 
> src/ and cmake spreads them all over build/*.  This makes that you can't 
> just add ./ to anything that would normally be in your path (or, 
> PATH=.:$PATH, and then run, say, ../qa/workunits/cephtool/test.sh).  
> There's a bunch of kludges in vstart.sh to make it work that I think 
> mostly point to this issue (and the .libs things).  Is there simply an 
> option we can give cmake to make it put built binaries directly in build/?
> 
> Stepping back a bit, it seems like the goals should be
> 
> 1. Be able to completely replace autotools.  I don't fancy maintaining 
> both in parallel.
> 
> 2. Be able to run vstart etc from the build dir.
> 
> 3. Be able to run ./ceph[-anything] from the build dir, or put the build 
> dir in the path.  (I suppose we could rely in a make install step, but 
> that seems like more hassle... hopefully it's not neceesary?)
> 
> 4. make check has to work
> 
> 5. Use make-dist.sh to generate a release tarball (not make dist)
> 
> 6. gitbuilders use make-dist.sh and cmake to build packages
> 
> 7. release process uses make-dist.sh and cmake to build a relelase
> 
> I'm probably missing something?
> 
> Should we set a target of doing the 10.0.2 or .3 with cmake?

An intermediate step could be to switch from using make check to using make distcheck. Once this works, all issues related to out-of-tree build and make check will be resolved. And deprecating autotools in favor of cmake will be just about that.

My 2cts

> 
> sage
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2015-12-16 17:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 17:33 cmake Sage Weil
2015-12-16 17:53 ` Loic Dachary [this message]
2015-12-16 18:28 ` cmake John Spray
2015-12-16 19:36   ` cmake Sage Weil
2015-12-16 18:45 ` cmake Yehuda Sadeh-Weinraub
2015-12-16 19:06   ` cmake Matt Benjamin
2015-12-16 19:38     ` cmake Sage Weil
2015-12-16 23:47       ` cmake Willem Jan Withagen
2015-12-16 23:36   ` cmake Willem Jan Withagen
  -- strict thread matches above, loose matches on Subject: below --
2016-06-27 17:50 cmake Sage Weil
2016-06-28  7:35 ` cmake Willem Jan Withagen
2016-06-28  8:41   ` cmake Willem Jan Withagen
2016-06-28  8:57     ` cmake Willem Jan Withagen
2016-06-28 13:42   ` cmake Sage Weil
2016-06-28 16:05     ` cmake Willem Jan Withagen
2016-06-29 16:51       ` cmake Willem Jan Withagen
2016-06-30 19:03         ` cmake Willem Jan Withagen
2016-07-05 19:09     ` cmake Willem Jan Withagen
2016-06-28 20:28 ` cmake Casey Bodley
2016-06-28 21:43   ` cmake Mark Nelson
2016-07-04  9:05 ` cmake Willem Jan Withagen
2016-07-04 10:37   ` cmake Brad Hubbard
2015-12-03 22:24 cmake Pete Zaitcev
2015-12-03 22:30 ` cmake Adam C. Emerson
2015-12-04  0:03   ` cmake Pete Zaitcev
2015-12-04  0:26     ` cmake Matt Benjamin
2015-12-04  8:59       ` cmake Pete Zaitcev
2015-12-04 14:15         ` cmake Daniel Gryniewicz
2015-12-03 22:30 ` cmake Matt Benjamin
2015-12-03 22:31   ` cmake Matt Benjamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5671A50E.4060302@dachary.org \
    --to=loic@dachary.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=sweil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox