From: Josh Durgin <jdurgin@redhat.com>
To: Wido den Hollander <wido@42on.com>, Jason Dillaman <dillaman@redhat.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>,
Alexandre DERUMIER <aderumier@odiso.com>
Subject: Re: Is rbd_discard enough to wipe an RBD image?
Date: Mon, 21 Dec 2015 14:20:07 -0800 [thread overview]
Message-ID: <56787B17.2000807@redhat.com> (raw)
In-Reply-To: <56784C4B.8020408@42on.com>
On 12/21/2015 11:00 AM, Wido den Hollander wrote:
> My discard code now works, but I wanted to verify. If I understand Jason
> correctly it would be a matter of figuring out the 'order' of a image
> and call rbd_discard in a loop until you reach the end of the image.
You'd need to get the order via rbd_stat(), convert it to object size
(i.e. (1 << order)), and fetch stripe_count with rbd_get_stripe_count().
Then do the discards in (object size * stripe_count) chunks. This
ensures you discard entire objects. This is the size you'd want to use
for import/export as well, ideally.
> I just want libvirt to be as feature complete as possible when it comes
> to RBD.
I see, makes sense.
Josh
next prev parent reply other threads:[~2015-12-21 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 21:21 Is rbd_discard enough to wipe an RBD image? Wido den Hollander
2015-12-21 14:25 ` Alexandre DERUMIER
2015-12-21 15:09 ` Jason Dillaman
2015-12-21 15:50 ` Josh Durgin
2015-12-21 19:00 ` Wido den Hollander
2015-12-21 22:20 ` Josh Durgin [this message]
2015-12-22 21:55 ` Wido den Hollander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56787B17.2000807@redhat.com \
--to=jdurgin@redhat.com \
--cc=aderumier@odiso.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dillaman@redhat.com \
--cc=wido@42on.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox