CEPH filesystem development
 help / color / mirror / Atom feed
From: Willem Jan Withagen <wjw@digiware.nl>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Asserts while running test/erasure-code/test-erasure-eio.sh
Date: Sun, 17 Jan 2016 17:32:09 +0100	[thread overview]
Message-ID: <569BC209.2000600@digiware.nl> (raw)


When I run the above script I get asserts:

osd/ECBackend.cc: 201: FAILED assert(res.errors.empty())

Which is in this code:
struct OnRecoveryReadComplete :
  public GenContext<pair<RecoveryMessages*, ECBackend::read_result_t& > &> {
  ECBackend *pg;
  hobject_t hoid;
  set<int> want;
  OnRecoveryReadComplete(ECBackend *pg, const hobject_t &hoid)
    : pg(pg), hoid(hoid) {}
  void finish(pair<RecoveryMessages *, ECBackend::read_result_t &> &in) {
    ECBackend::read_result_t &res = in.second;
    // FIXME???
    assert(res.r == 0);
    assert(res.errors.empty());
    assert(res.returned.size() == 1);
    pg->handle_recovery_read_complete(
      hoid,
      res.returned.back(),
      res.attrs,
      in.first);
  }
};

Now the //FIXME remark suggests that the code could be not oke.
And/or the asserts are too strong.
Any hints, suggestions or questions to fix this.

--WjW




             reply	other threads:[~2016-01-17 16:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-17 16:32 Willem Jan Withagen [this message]
     [not found] ` <CAJ4mKGbCjXt5MxxpvMVXoJcTUuCvgzCzzhh+9v7+p+qhvS9pQA@mail.gmail.com>
2016-01-18 19:38   ` Asserts while running test/erasure-code/test-erasure-eio.sh Willem Jan Withagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569BC209.2000600@digiware.nl \
    --to=wjw@digiware.nl \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox