From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jevon Qiao Subject: Re: [Qemu-devel] [PATCH] add CephFS support in VirtFS Date: Thu, 18 Feb 2016 09:39:03 +0800 Message-ID: <56C520B7.60907@gmail.com> References: <56C00B60.6000502@gmail.com> <20160215091727.GB3105@redhat.com> <56C421F6.1000102@gmail.com> <20160217093716.GC30300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:35706 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424516AbcBRBjH (ORCPT ); Wed, 17 Feb 2016 20:39:07 -0500 Received: by mail-pa0-f46.google.com with SMTP id ho8so21591503pac.2 for ; Wed, 17 Feb 2016 17:39:05 -0800 (PST) In-Reply-To: <20160217093716.GC30300@redhat.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: "Daniel P. Berrange" Cc: "ceph-devel@vger.kernel.org" , qemu-devel@nongnu.org, haomaiwang@gmail.com, mst@redhat.com, aneesh.kumar@linux.vnet.ibm.com, Sage Weil , gfarnum@redhat.com, gkurz@linux.vnet.ibm.com On 17/2/16 17:37, Daniel P. Berrange wrote: > On Wed, Feb 17, 2016 at 03:32:06PM +0800, Jevon Qiao wrote: >> Hi Daniel, >> >> Thank you for reviewing my code, please see my reply in-line. >> On 15/2/16 17:17, Daniel P. Berrange wrote: >>> On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote: >>>> + >>>> +static int cephfs_parse_opts(QemuOpts *opts, struct FsDriverEntry *fse) >>>> +{ >>>> + const char *sec_model = qemu_opt_get(opts, "security_model"); >>>> + const char *path = qemu_opt_get(opts, "path"); >>>> + >>>> + if (!sec_model) { >>>> + fprintf(stderr, "Invalid argument security_model specified with " >>>> + "cephfs fsdriver\n"); >>> Bad indent. >> BTW, is there any tool I can use to check the coding style in Qemu? > As already mentioned there is 'scripts/checkpatch.pl'. If you are just > wanting to check a single patch before sending it you can run it > manually eg > > git show | ./scripts/checkpatch.pl - > > If you have a branch holding a whole series of patches to submit, then > it is easier to automate it. eg > > git rebase -i master -x 'git show | ./scripts/checkpatch.pl -' Thank you for the detailed answers. > NB, the script doesn't catch all style problems, but it does a pretty > good job. So even if the script passes, don't be suprised if reviewers > point out further style issues. Good to know:-) . Thanks, Jevon > Regards, > Daniel