From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org
Cc: Varada Kari <Varada.Kari@sandisk.com>
Subject: Re: [PATCH 3/4] libceph: don't spam dmesg with stray reply warnings
Date: Sat, 20 Feb 2016 12:46:07 -0600 [thread overview]
Message-ID: <56C8B46F.5020408@ieee.org> (raw)
In-Reply-To: <1455986729-12544-4-git-send-email-idryomov@gmail.com>
On 02/20/2016 10:45 AM, Ilya Dryomov wrote:
> Commit d15f9d694b77 ("libceph: check data_len in ->alloc_msg()")
> mistakenly bumped the log level on the "tid %llu unknown, skipping"
> message. Turn it back into a dout() - stray replies are perfectly
> normal when OSDs flap, crash, get killed for testing purposes, etc.
>
> Cc: stable@vger.kernel.org # 4.3+
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> net/ceph/osd_client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index 7c1a5d1734c3..32355d9d0103 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -2890,8 +2890,8 @@ static struct ceph_msg *get_reply(struct ceph_connection *con,
> mutex_lock(&osdc->request_mutex);
> req = __lookup_request(osdc, tid);
> if (!req) {
> - pr_warn("%s osd%d tid %llu unknown, skipping\n",
> - __func__, osd->o_osd, tid);
> + dout("%s osd%d tid %llu unknown, skipping\n", __func__,
> + osd->o_osd, tid);
> m = NULL;
> *skip = 1;
> goto out;
>
next prev parent reply other threads:[~2016-02-20 18:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 16:45 [PATCH 0/4] libceph: message skipping fixes Ilya Dryomov
2016-02-20 16:45 ` [PATCH 1/4] libceph: don't bail early from try_read() when skipping a message Ilya Dryomov
2016-02-20 18:28 ` Alex Elder
2016-02-20 20:21 ` Ilya Dryomov
2016-02-20 20:38 ` Alex Elder
2016-02-20 16:45 ` [PATCH 2/4] libceph: use the right footer size " Ilya Dryomov
2016-02-20 18:44 ` Alex Elder
2016-02-20 20:05 ` Ilya Dryomov
2016-02-20 20:15 ` Alex Elder
2016-02-21 14:31 ` Ilya Dryomov
2016-02-21 14:35 ` [PATCH 4/4] libceph: use sizeof_footer() more Ilya Dryomov
2016-02-21 15:08 ` Alex Elder
2016-02-20 16:45 ` [PATCH 3/4] libceph: don't spam dmesg with stray reply warnings Ilya Dryomov
2016-02-20 18:46 ` Alex Elder [this message]
2016-02-20 16:45 ` [PATCH 4/4] libceph: use sizeof_footer() in ceph_msg_revoke() Ilya Dryomov
2016-02-20 18:47 ` Alex Elder
2016-02-20 19:51 ` Ilya Dryomov
2016-02-20 19:56 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C8B46F.5020408@ieee.org \
--to=elder@ieee.org \
--cc=Varada.Kari@sandisk.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox