From: Jeff Layton <jlayton@kernel.org>
To: "Yan, Zheng" <zyan@redhat.com>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH v5 0/7] ceph: don't request caps for idle open files
Date: Thu, 05 Mar 2020 10:32:20 -0500 [thread overview]
Message-ID: <6bc88d487b99ec0cb2721151a706242d9c213dfd.camel@kernel.org> (raw)
In-Reply-To: <20200305122105.69184-1-zyan@redhat.com>
On Thu, 2020-03-05 at 20:20 +0800, Yan, Zheng wrote:
> This series make cephfs client not request caps for open files that
> idle for a long time. For the case that one active client and multiple
> standby clients open the same file, this increase the possibility that
> mds issues exclusive caps to the active client.
>
> Yan, Zheng (7):
> ceph: always renew caps if mds_wanted is insufficient
> ceph: consider inode's last read/write when calculating wanted caps
> ceph: remove delay check logic from ceph_check_caps()
> ceph: simplify calling of ceph_get_fmode()
> ceph: update i_requested_max_size only when sending cap msg to auth mds
> ceph: check all mds' caps after page writeback
> ceph: calculate dir's wanted caps according to recent dirops
>
> fs/ceph/caps.c | 360 ++++++++++++++++-------------------
> fs/ceph/dir.c | 21 +-
> fs/ceph/file.c | 45 ++---
> fs/ceph/inode.c | 21 +-
> fs/ceph/ioctl.c | 2 +
> fs/ceph/mds_client.c | 16 +-
> fs/ceph/super.h | 37 ++--
> include/linux/ceph/ceph_fs.h | 1 +
> 8 files changed, 243 insertions(+), 260 deletions(-)
>
> changes since v2
> - make __ceph_caps_file_wanted() more readable
> - add patch 5 and 6, which fix hung write during testing patch 1~4
>
> changes since v3
> - don't queue delayed cap check for snap inode
> - initialize ci->{last_rd,last_wr} to jiffies - 3600 * HZ
> - make __ceph_caps_file_wanted() check inode type
>
> changes since v4
> - add patch 7, improve how to calculate dir's wanted caps
>
Thanks Zheng. This one seems to work just fine. Merged into ceph-
client/testing branch with the following changes:
- squashed patch 7 into patch 2
- cleaned up a few changelog grammatical and spelling errors
- fix a small bit of whitespace damage
Thanks!
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2020-03-05 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 12:20 [PATCH v5 0/7] ceph: don't request caps for idle open files Yan, Zheng
2020-03-05 12:20 ` [PATCH v5 1/7] ceph: always renew caps if mds_wanted is insufficient Yan, Zheng
2020-03-05 12:21 ` [PATCH v5 2/7] ceph: consider inode's last read/write when calculating wanted caps Yan, Zheng
2020-03-05 12:21 ` [PATCH v5 3/7] ceph: remove delay check logic from ceph_check_caps() Yan, Zheng
2020-03-05 12:21 ` [PATCH v5 4/7] ceph: simplify calling of ceph_get_fmode() Yan, Zheng
2020-03-05 12:21 ` [PATCH v5 5/7] ceph: update i_requested_max_size only when sending cap msg to auth mds Yan, Zheng
2020-03-05 12:21 ` [PATCH v5 6/7] ceph: check all mds' caps after page writeback Yan, Zheng
2020-03-05 12:21 ` [PATCH v5 7/7] ceph: calculate dir's wanted caps according to recent dirops Yan, Zheng
2020-03-05 15:32 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bc88d487b99ec0cb2721151a706242d9c213dfd.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox