From: Matt Benjamin <mbenjamin@redhat.com>
To: Chen Min <chenmin@xsky.com>
Cc: The Sacred Order of the Squid Cybernetic <ceph-devel@vger.kernel.org>
Subject: rename PR
Date: Fri, 9 Sep 2016 10:16:30 -0400 (EDT) [thread overview]
Message-ID: <71460615.83653154.1473430590652.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <580189648.83640635.1473430099895.JavaMail.zimbra@redhat.com>
Hi Chen,
I wanted to let you know, I merged your exact-match PR. Now, I suspect that you're also not running a recent-enough version of nfs-ganesha, because I think that the rename issue you fixed wouldn't easily reproduce if you were.
A key point I wanted to highlight is that it's part of the scaling (and ha, and...) strategy that our nfs file handles are name-stable, rather than arbitrary values. One implication of that is that when a file is renamed, the renamed object has a different file id and hence NFS file handle value than it did before the rename. We use the parent directory's change attribute to ensure that clients that had the vnode cached see an invalidate. (Nothing in your PR contradicts that, of course.)
Another strategic decision we made is, we don't rename directories (just stating it for posterity). :)
Cheers,
Matt
--
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://www.redhat.com/en/technologies/storage
tel. 734-707-0660
fax. 734-769-8938
cel. 734-216-5309
parent reply other threads:[~2016-09-09 14:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <580189648.83640635.1473430099895.JavaMail.zimbra@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71460615.83653154.1473430590652.JavaMail.zimbra@redhat.com \
--to=mbenjamin@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chenmin@xsky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox