From: Jason Dillaman <dillaman@redhat.com>
To: Wido den Hollander <wido@42on.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: Speeding up rbd_stat() in libvirt
Date: Mon, 4 Jan 2016 10:38:36 -0500 (EST) [thread overview]
Message-ID: <780342854.4132479.1451921916433.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <56813DB8.2060008@42on.com>
Short term, assuming there wouldn't be an objection from the libvirt community, I think spawning a thread pool and concurrently executing several rbd_stat calls concurrently would be the easiest and cleanest solution. I wouldn't suggest trying to roll your own solution for retrieving image sizes for format 1 and 2 RBD images directly within libvirt.
Longer term, given this use case, perhaps it would make sense to add an async version of rbd_open. The rbd_stat call itself just reads the data from memory initialized by rbd_open. On the Jewel branch, librbd has had some major rework and image loading is asynchronous under the hood already.
--
Jason Dillaman
----- Original Message -----
> From: "Wido den Hollander" <wido@42on.com>
> To: ceph-devel@vger.kernel.org
> Sent: Monday, December 28, 2015 8:48:40 AM
> Subject: Speeding up rbd_stat() in libvirt
>
> Hi,
>
> The storage pools of libvirt know a mechanism called 'refresh' which
> will scan a storage pool to refresh the contents.
>
> The current implementation does:
> * List all images via rbd_list()
> * Call rbd_stat() on each image
>
> Source:
> http://libvirt.org/git/?p=libvirt.git;a=blob;f=src/storage/storage_backend_rbd.c;h=cdbfdee98505492407669130712046783223c3cf;hb=master#l329
>
> This works, but a RBD pool with 10k images takes a couple of minutes to
> scan.
>
> Now, Ceph is distributed, so this could be done in parallel, but before
> I start on this I was wondering if somebody had a good idea to fix this?
>
> I don't know if it is allowed in libvirt to spawn multiple threads and
> have workers do this, but it was something which came to mind.
>
> libvirt only wants to know the size of a image and this is now stored in
> the rbd_directory object, so the rbd_stat() is required.
>
> Suggestions or ideas? I would like to have this process to be as fast as
> possible.
>
> Wido
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-01-04 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 13:48 Speeding up rbd_stat() in libvirt Wido den Hollander
2016-01-04 15:38 ` Jason Dillaman [this message]
2016-01-04 15:59 ` Wido den Hollander
2016-01-06 15:31 ` Wido den Hollander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780342854.4132479.1451921916433.JavaMail.zimbra@redhat.com \
--to=dillaman@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=wido@42on.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox