From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37932C4742C for ; Sun, 1 Nov 2020 16:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCA0722265 for ; Sun, 1 Nov 2020 16:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="1fh8hw1b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgKAQqY (ORCPT ); Sun, 1 Nov 2020 11:46:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727011AbgKAQqY (ORCPT ); Sun, 1 Nov 2020 11:46:24 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48F5FC061A04 for ; Sun, 1 Nov 2020 08:46:24 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id y14so8934291pfp.13 for ; Sun, 01 Nov 2020 08:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZnX97cZi6Tq1d5eR74IXiOWMCb5Il9NZ1Se/Vo5HW5E=; b=1fh8hw1b4PtM43PjPjUPsgwnC03eOzq1D/OIFg9Z2RLVbDo9D2nclogiTHPlZ9q9gq rrmC+XRj9jIExjEAIOBmizVgp08ZK+1BOrKNPSsqt6PXuv87piwipBy0tmkGDLci20YZ JR2v8tDBzCXLzUsRIF3SNeDwpgOyDiUoBmGT/dKyCVInbDNsH3XW6LdeawRrzdGSBvi3 mi2Zd1b281L8/5BerY1o0iDfhGaz4v1tgb6OR3HUy1joR3/yNIFriK7SN7QateperW5W 2nQPknP0sHnoa1Z7dhknzTXPvkZP1QGclC+Qpgjo7CRH5NKu46KBXTrYpjYhzZx1X2si M+Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZnX97cZi6Tq1d5eR74IXiOWMCb5Il9NZ1Se/Vo5HW5E=; b=iomGL9lfb0xYwvJHKxPXsLrQLeS52/MSu9wS928D3uSzScfPCpzvazzCynia9z6Vd0 pIBNQ4xq7ZCO18UVL67mtuXc9f+XEqbRaWclNS8K0/XZ2HIf8wgJWLubq2XpNAAVnE1e I/vtTmJR+LRGeKgk86MWZAC4it8lRCoXeuvglwEZijHz4UR5xH2JP6cjmCIkqX7qQvtG 5ffwI1ey+JgpzsSTBZtKXevVozfDo0iBtops8aW9xA24FMLj3tGiA3GNAr5MzF9Fvwlt QAxF85FGm7n3b6idNyv+4b7nggTEq0iSeMrDlnzZ11q8tr9zfNT/AOf6nXAoL5de7ckz uAlw== X-Gm-Message-State: AOAM531weFSQBDABileP/FZAyg1S6jl6USXBg7+URHQuXGdnpZzGsvm/ VbPQApwSf5RPjVRE6Cw5wY1eIQ== X-Google-Smtp-Source: ABdhPJxTQE4+lDH2ha7od50bGb6ipTN3YldzqLbuO9m9iCrZbUFUOoR3Y6ocz+rikoLtjR5mdUiVNw== X-Received: by 2002:a63:d74b:: with SMTP id w11mr10225608pgi.147.1604249183766; Sun, 01 Nov 2020 08:46:23 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id t74sm1926656pfc.47.2020.11.01.08.46.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Nov 2020 08:46:23 -0800 (PST) Subject: Re: block ioctl cleanups To: Christoph Hellwig Cc: Ilya Dryomov , Song Liu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Stefan Haberland , Jan Hoeppner , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org References: <20201031085810.450489-1-hch@lst.de> From: Jens Axboe Message-ID: <877901e6-6cdb-42e9-3b32-cb8b93bfff4e@kernel.dk> Date: Sun, 1 Nov 2020 09:46:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201031085810.450489-1-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On 10/31/20 2:57 AM, Christoph Hellwig wrote: > Hi Jens, > > this series has a bunch of cleanups for the block layer ioctl code. > > Diffstat: > block/genhd.c | 7 ---- > block/ioctl.c | 62 ++++++-------------------------------- > drivers/block/loop.c | 2 - > drivers/block/mtip32xx/mtip32xx.c | 11 +----- > drivers/block/pktcdvd.c | 6 ++- > drivers/block/rbd.c | 41 ++----------------------- > drivers/md/bcache/request.c | 5 +-- > drivers/md/dm.c | 5 ++- > drivers/md/md.c | 62 +++++++++++++++++++------------------- > drivers/mtd/mtd_blkdevs.c | 28 ----------------- > drivers/s390/block/dasd.c | 1 > drivers/s390/block/dasd_int.h | 3 + > drivers/s390/block/dasd_ioctl.c | 27 +++++----------- > include/linux/blkdev.h | 3 - > include/linux/genhd.h | 1 > 15 files changed, 73 insertions(+), 191 deletions(-) Series looks good to me, apart from the mentioned mtip32xx change. If you repost this, can you look through commit messages and titles for typos, I spotted quite a few. If not I'll do it when applying. -- Jens Axboe