From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E772EC3527A for ; Mon, 14 Dec 2020 17:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 850F222CAE for ; Mon, 14 Dec 2020 17:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440367AbgLNR0n (ORCPT ); Mon, 14 Dec 2020 12:26:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:42782 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439009AbgLNR0a (ORCPT ); Mon, 14 Dec 2020 12:26:30 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AEDB2AC10; Mon, 14 Dec 2020 17:25:49 +0000 (UTC) Received: from localhost (brahms [local]) by brahms (OpenSMTPD) with ESMTPA id 18136ba1; Mon, 14 Dec 2020 17:26:18 +0000 (UTC) From: Luis Henriques To: Ilya Dryomov Cc: Ceph Development Subject: Re: wip-msgr2 References: <87wnxk1iwy.fsf@suse.de> Date: Mon, 14 Dec 2020 17:26:18 +0000 In-Reply-To: (Ilya Dryomov's message of "Mon, 14 Dec 2020 17:59:43 +0100") Message-ID: <87sg881epx.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org Ilya Dryomov writes: > On Mon, Dec 14, 2020 at 4:55 PM Luis Henriques wrote: >> >> Ilya Dryomov writes: >> >> > Hello, >> > >> > I've pushed wip-msgr2 and opened a dummy PR in ceph-client: >> > >> > https://github.com/ceph/ceph-client/pull/22 >> > >> > This set has been through a over a dozen krbd test suite runs with no >> > issues other than those with the test suite itself. The diffstat is >> > rather big, so I didn't want to spam the list. If someone wants it >> > posted, let me know. Any comments are welcome! >> >> That's *awesome*! Thanks for sharing, Ilya. Obviously this will need a >> lot of time to digest but a quick attempt to do a mount using a v2 monitor >> is just showing me a bunch of: >> >> libceph: mon0 (1)192.168.155.1:40898 socket closed (con state V1_BANNER) >> >> Note that this was just me giving it a try with a dummy vstart cluster >> (octopus IIRC), so nothing that could be considered testing. I'll try to >> find out what I'm doing wrong in the next couple of days or, worst case, >> after EOY vacations. > > Hi Luis, > > This is because the kernel continues to default to msgr1. The socket > gets closed by the mon right after it sees msgr1 banner and you should > see "peer ... is using msgr V1 protocol" error in the log. > > For msgr2, you need to select a connection mode using the new ms_mode > option: > > ms_mode=legacy - msgr1 (default) > ms_mode=crc - crc mode, if denied fail > ms_mode=secure - secure mode, if denied fail > ms_mode=prefer-crc - crc mode, if denied agree to secure mode > ms_mode=prefer-secure - secure mode, if denied agree to crc mode Ah, right. I should have took a quick look at the patches first to check for any new parameters. Thanks for pointing me at that, I'll retry my test using ms_mode. Cheers, -- Luis