From: Luis Henriques <lhenriques@suse.de>
To: Jeff Layton <jlayton@kernel.org>
Cc: ceph-devel@vger.kernel.org, idryomov@gmail.com, pdonnell@redhat.com
Subject: Re: [PATCH v2] ceph: ensure we have Fs caps when fetching dir link count
Date: Wed, 11 Nov 2020 13:24:03 +0000 [thread overview]
Message-ID: <87tutwdo24.fsf@suse.de> (raw)
In-Reply-To: <389065486cd51a9ceebe6edf9d1b3ea84129a62d.camel@kernel.org> (Jeff Layton's message of "Wed, 11 Nov 2020 07:53:43 -0500")
Jeff Layton <jlayton@kernel.org> writes:
> On Wed, 2020-11-11 at 09:34 +0000, Luis Henriques wrote:
>> Jeff Layton <jlayton@kernel.org> writes:
>>
>> > The link count for a directory is defined as inode->i_subdirs + 2,
>> > (for "." and ".."). i_subdirs is only populated when Fs caps are held.
>> > Ensure we grab Fs caps when fetching the link count for a directory.
>> >
>>
>> Maybe this would be worth a stable@ tag too...?
>>
>> Cheers,
>
> Usually I reserve stable tags for "real problems" (oopses, etc), that we
> want to send to mainline immediately. This is just a subtle case where
> the link count in a stat() call ends up looking wrong.
>
> If someone wants to make a case for stable, I'm willing to listen, but
> this one doesn't seem worth it.
Ok, fair enough.
Cheers,
--
Luis
prev parent reply other threads:[~2020-11-11 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 16:30 [PATCH v2] ceph: ensure we have Fs caps when fetching dir link count Jeff Layton
2020-11-11 9:34 ` Luis Henriques
2020-11-11 12:53 ` Jeff Layton
2020-11-11 13:24 ` Luis Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tutwdo24.fsf@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=pdonnell@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox